From: Greg KH <gregkh@suse.de>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: alsa-devel@alsa-project.org,
sakari.ailus@maxwell.research.nokia.com,
broonie@opensource.wolfsonmicro.com, clemens@ladisch.de,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org
Subject: Re: [RFC/PATCH v7 01/12] media: Media device node support
Date: Wed, 22 Dec 2010 19:34:54 -0800 [thread overview]
Message-ID: <20101223033454.GC14692@suse.de> (raw)
In-Reply-To: <1292844995-7900-2-git-send-email-laurent.pinchart@ideasonboard.com>
On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote:
> +/*
> + * Flag to mark the media_devnode struct as registered. Drivers must not touch
> + * this flag directly, it will be set and cleared by media_devnode_register and
> + * media_devnode_unregister.
> + */
> +#define MEDIA_FLAG_REGISTERED 0
It's a define, not a flag, or anything that any driver could touch.
And if you don't want anyone to touch the thing, then make it private
and unable to be touched by anyone else. Otherwise it will be
touched...
thanks,
greg k-h
next prev parent reply other threads:[~2010-12-23 3:34 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 11:36 [RFC/PATCH v7 00/12] Media controller (core and V4L2) Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 01/12] media: Media device node support Laurent Pinchart
2010-12-23 3:32 ` Greg KH
2010-12-24 11:59 ` Laurent Pinchart
2011-01-06 22:19 ` Greg KH
2011-01-06 23:27 ` Hans Verkuil
2011-01-06 23:46 ` Greg KH
2011-01-10 14:09 ` Laurent Pinchart
2011-01-11 0:15 ` Raymond Yau
2010-12-23 3:34 ` Greg KH [this message]
2010-12-20 11:36 ` [RFC/PATCH v7 02/12] media: Media device Laurent Pinchart
2010-12-23 3:33 ` Greg KH
2010-12-24 12:01 ` Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 03/12] media: Entities, pads and links Laurent Pinchart
2010-12-21 16:22 ` Hans Verkuil
2010-12-23 9:05 ` Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 04/12] media: Entity graph traversal Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 05/12] media: Reference count and power handling Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 06/12] media: Media device information query Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 07/12] media: Entities, pads and links enumeration Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 08/12] media: Links setup Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 09/12] media: Pipelines and media streams Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 10/12] v4l: Add a media_device pointer to the v4l2_device structure Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 11/12] v4l: Make video_device inherit from media_entity Laurent Pinchart
2010-12-20 11:36 ` [RFC/PATCH v7 12/12] v4l: Make v4l2_subdev " Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2011-01-07 0:24 [RFC/PATCH v7 01/12] media: Media device node support Andy Walls
2011-01-07 0:31 ` Greg KH
2011-01-07 1:04 Andy Walls
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101223033454.GC14692@suse.de \
--to=gregkh@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clemens@ladisch.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@maxwell.research.nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).