From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: David Lambert <dlambert@ti.com>
Cc: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
Liam Girdwood <lrg@slimlogic.co.uk>,
Tony Lindgren <tony@atomide.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH 3/5] ASoC: DMIC: Adding OMAP DMIC driver to build
Date: Tue, 28 Dec 2010 11:40:00 +0000 [thread overview]
Message-ID: <20101228114000.GD31292@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1293509826-23253-4-git-send-email-dlambert@ti.com>
On Mon, Dec 27, 2010 at 10:17:04PM -0600, David Lambert wrote:
> Adds the OMAP DMIC driver and codec to the build.
>
> Signed-off-by: David Lambert <dlambert@ti.com>
> ---
> sound/soc/codecs/Kconfig | 3 +++
> sound/soc/codecs/Makefile | 2 ++
> sound/soc/omap/Kconfig | 5 +++++
> sound/soc/omap/Makefile | 2 ++
This should be one of the last patches in the series, but given the sort
of drivers you're introducing I'd expect the drivers to just directly
add the build system stuff in the patch.
> 4 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig
> index 0f33db2..f6c6d31 100644
> --- a/sound/soc/codecs/Kconfig
> +++ b/sound/soc/codecs/Kconfig
> @@ -166,6 +166,9 @@ config SND_SOC_L3
> config SND_SOC_DA7210
> tristate
>
> +config SND_SOC_DMIC
> + tristate
> +
> config SND_SOC_MAX98088
> tristate
>
> diff --git a/sound/soc/codecs/Makefile b/sound/soc/codecs/Makefile
> index 10e5e09..9139cf9 100644
> --- a/sound/soc/codecs/Makefile
> +++ b/sound/soc/codecs/Makefile
> @@ -14,6 +14,7 @@ snd-soc-cs42l51-objs := cs42l51.o
> snd-soc-cs4270-objs := cs4270.o
> snd-soc-cx20442-objs := cx20442.o
> snd-soc-da7210-objs := da7210.o
> +snd-soc-dmic-objs := dmic.o
> snd-soc-l3-objs := l3.o
> snd-soc-max98088-objs := max98088.o
> snd-soc-pcm3008-objs := pcm3008.o
> @@ -91,6 +92,7 @@ obj-$(CONFIG_SND_SOC_CS42L51) += snd-soc-cs42l51.o
> obj-$(CONFIG_SND_SOC_CS4270) += snd-soc-cs4270.o
> obj-$(CONFIG_SND_SOC_CX20442) += snd-soc-cx20442.o
> obj-$(CONFIG_SND_SOC_DA7210) += snd-soc-da7210.o
> +obj-$(CONFIG_SND_SOC_DMIC) += snd-soc-dmic.o
> obj-$(CONFIG_SND_SOC_L3) += snd-soc-l3.o
> obj-$(CONFIG_SND_SOC_JZ4740_CODEC) += snd-soc-jz4740-codec.o
> obj-$(CONFIG_SND_SOC_MAX98088) += snd-soc-max98088.o
> diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
> index a088db6..548b13c 100644
> --- a/sound/soc/omap/Kconfig
> +++ b/sound/soc/omap/Kconfig
> @@ -9,6 +9,9 @@ config SND_OMAP_SOC_MCBSP
> config SND_OMAP_SOC_MCPDM
> tristate
>
> +config SND_OMAP_SOC_DMIC
> + tristate
> +
> config SND_OMAP_SOC_N810
> tristate "SoC Audio support for Nokia N810"
> depends on SND_OMAP_SOC && MACH_NOKIA_N810 && I2C
> @@ -103,6 +106,8 @@ config SND_OMAP_SOC_SDP4430
> depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP_4430SDP
> select SND_OMAP_SOC_MCPDM
> select SND_SOC_TWL6040
> + select SND_SOC_DMIC
> + select SND_OMAP_SOC_DMIC
> help
> Say Y if you want to add support for SoC audio on Texas Instruments
> SDP4430.
> diff --git a/sound/soc/omap/Makefile b/sound/soc/omap/Makefile
> index ba9fc65..6ff27f5 100644
> --- a/sound/soc/omap/Makefile
> +++ b/sound/soc/omap/Makefile
> @@ -1,9 +1,11 @@
> # OMAP Platform Support
> snd-soc-omap-objs := omap-pcm.o
> +snd-soc-omap-dmic-objs := omap-dmic.o
> snd-soc-omap-mcbsp-objs := omap-mcbsp.o
> snd-soc-omap-mcpdm-objs := omap-mcpdm.o mcpdm.o
>
> obj-$(CONFIG_SND_OMAP_SOC) += snd-soc-omap.o
> +obj-$(CONFIG_SND_OMAP_SOC_DMIC) += snd-soc-omap-dmic.o
> obj-$(CONFIG_SND_OMAP_SOC_MCBSP) += snd-soc-omap-mcbsp.o
> obj-$(CONFIG_SND_OMAP_SOC_MCPDM) += snd-soc-omap-mcpdm.o
>
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2010-12-28 11:40 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 4:17 [PATCH 0/5] Adding OMAP DMIC driver to kernel David Lambert
2010-12-28 4:17 ` [PATCH 1/5] ASoC: DMIC: Adding the OMAP DMIC driver David Lambert
2010-12-28 11:14 ` Felipe Balbi
2010-12-29 1:13 ` Lambert, David
2010-12-29 9:47 ` Felipe Balbi
2010-12-29 10:35 ` Liam Girdwood
2010-12-29 10:44 ` Felipe Balbi
2010-12-29 11:52 ` Liam Girdwood
2010-12-29 11:56 ` Mark Brown
2010-12-29 11:59 ` Felipe Balbi
2010-12-29 12:11 ` Mark Brown
2010-12-29 12:04 ` Felipe Balbi
2010-12-29 13:00 ` Liam Girdwood
2010-12-29 13:07 ` Felipe Balbi
2010-12-28 14:18 ` Mark Brown
2011-01-05 13:56 ` Lambert, David
2011-01-05 14:03 ` Mark Brown
2010-12-28 4:17 ` [PATCH 2/5] ASoC: DMIC codec: Adding a generic DMIC codec David Lambert
2010-12-28 14:29 ` Mark Brown
2010-12-28 4:17 ` [PATCH 3/5] ASoC: DMIC: Adding OMAP DMIC driver to build David Lambert
2010-12-28 11:40 ` Mark Brown [this message]
2010-12-29 2:21 ` Lambert, David
2010-12-28 4:17 ` [PATCH 4/5] OMAP4: hwmod: add entries for DMIC driver David Lambert
2010-12-28 4:17 ` [PATCH 5/5] MAP4: DMIC: Add DMIC codec platform devices David Lambert
2010-12-28 11:23 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228114000.GD31292@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dlambert@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).