Re: [PATCH 3/4] ASoC sst: Add mid machine driver

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Mon, Jan 03, 2011 at 11:09:16AM +0530, Koul, Vinod wrote:

> > If this is intended to be
> > a generic driver that manages the interaction with your BIOS then I'd
> > expect to see something like that.  If it's a driver for a specific
> > system then I'd expect the driver to say what it's a driver for.

> No, per your suggestion we made it machine specific driver. Yes will rename it
> to mid_machine_mfld as this is Medfield specific machine driver
> Does that fix your concern?

That helps but in that case you also need to remove all the device
registration stuff except for the actual machine driver from the init
and exit functions.  The CPU stuff is all a fixed property of the CPU
and should be reigstered by the architecture code (possibly with some
control for the individual machine), the CODEC should be being
enumerated by whatever normally does that.  The only thing this driver
should be doing is specifying how these things are connected.

> > Also, looking at your CODEC driver I'm not seeing anything that looks
> > like the handling for the three "nameless" CODEC vendors you've got -
> > given that you've got vendor workarounds in the code there this is
> > really surprising.

> The msic.c is msic codec which is specific to Medfield platform only. The other
> three codecs are for Moorestown and we will add them ( 3 separate codec drivers)
> when we add Moorestown machine (next after completing this)

What exactly is the msic CODEC?  Given the references to non-specific
"vendor" registers it doesn't sound like a particular CODEC driver.