From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"alan@linux.intel.com" <alan@linux.intel.com>,
"Harsha, Priya" <priya.harsha@intel.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/4] ASoC sst: Add mid machine driver
Date: Tue, 4 Jan 2011 13:39:13 +0000 [thread overview]
Message-ID: <20110104133913.GA24774@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <438BB0150E931F4B9CE701519A44630104C10F2F06@bgsmsx502.gar.corp.intel.com>
On Mon, Jan 03, 2011 at 11:04:11PM +0530, Koul, Vinod wrote:
> Thanks, I will add the soc-audio only and move the others to core.
> So now this machine driver will only add machine controls and dai link along with soc-audio device.
> Would that suffice
That sounds reasonable; I'd need to see the code to confirm.
> This is codec from TI and I will remove the msic name now.
> It will now be ti-sn95031.c
> Does this address your concern on this issue?
Normally Linux just uses the part name so that'd just be sn95031 - look
at the other CODEC drivers for example. In general you should try to
make your code look as similar as possible to what other systems are
doing.
next prev parent reply other threads:[~2011-01-04 13:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-30 11:13 [PATCH 3/4] ASoC sst: Add mid machine driver Vinod Koul
2011-01-02 13:47 ` Mark Brown
2011-01-03 5:39 ` Koul, Vinod
2011-01-03 15:43 ` Mark Brown
2011-01-03 16:01 ` Koul, Vinod
2011-01-03 16:28 ` Mark Brown
2011-01-03 17:34 ` Koul, Vinod
2011-01-04 13:39 ` Mark Brown [this message]
2011-01-03 16:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110104133913.GA24774@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alan@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).