* [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers
@ 2011-01-05 10:05 Jarkko Nikula
2011-01-05 11:00 ` Liam Girdwood
2011-01-05 11:29 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Jarkko Nikula @ 2011-01-05 10:05 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
After multi-component conversion these machine drivers don't actually need
anything from sound/soc/codecs/tlv320aic3x.h so don't include it.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
---
rx51.c and n810.c compile tested but these other machine drivers seems to not
use anything from tlv320aic3x.h either so should be safe to remove.
---
sound/soc/davinci/davinci-evm.c | 1 -
sound/soc/omap/n810.c | 1 -
sound/soc/omap/rx51.c | 1 -
sound/soc/s6000/s6105-ipcam.c | 1 -
sound/soc/samsung/s3c24xx_simtec_hermes.c | 2 --
5 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c
index 24b031e..0c2d6ba 100644
--- a/sound/soc/davinci/davinci-evm.c
+++ b/sound/soc/davinci/davinci-evm.c
@@ -26,7 +26,6 @@
#include <mach/edma.h>
#include <mach/mux.h>
-#include "../codecs/tlv320aic3x.h"
#include "davinci-pcm.h"
#include "davinci-i2s.h"
#include "davinci-mcasp.h"
diff --git a/sound/soc/omap/n810.c b/sound/soc/omap/n810.c
index fe215f3..83d213b 100644
--- a/sound/soc/omap/n810.c
+++ b/sound/soc/omap/n810.c
@@ -35,7 +35,6 @@
#include "omap-mcbsp.h"
#include "omap-pcm.h"
-#include "../codecs/tlv320aic3x.h"
#define N810_HEADSET_AMP_GPIO 10
#define N810_SPEAKER_AMP_GPIO 101
diff --git a/sound/soc/omap/rx51.c b/sound/soc/omap/rx51.c
index 150042a..09fb0df 100644
--- a/sound/soc/omap/rx51.c
+++ b/sound/soc/omap/rx51.c
@@ -36,7 +36,6 @@
#include "omap-mcbsp.h"
#include "omap-pcm.h"
-#include "../codecs/tlv320aic3x.h"
#define RX51_TVOUT_SEL_GPIO 40
#define RX51_JACK_DETECT_GPIO 177
diff --git a/sound/soc/s6000/s6105-ipcam.c b/sound/soc/s6000/s6105-ipcam.c
index bf3f3f9..5890e43 100644
--- a/sound/soc/s6000/s6105-ipcam.c
+++ b/sound/soc/s6000/s6105-ipcam.c
@@ -21,7 +21,6 @@
#include <variant/dmac.h>
-#include "../codecs/tlv320aic3x.h"
#include "s6000-pcm.h"
#include "s6000-i2s.h"
diff --git a/sound/soc/samsung/s3c24xx_simtec_hermes.c b/sound/soc/samsung/s3c24xx_simtec_hermes.c
index 0083aff..bb4292e 100644
--- a/sound/soc/samsung/s3c24xx_simtec_hermes.c
+++ b/sound/soc/samsung/s3c24xx_simtec_hermes.c
@@ -21,8 +21,6 @@
#include "s3c24xx-i2s.h"
#include "s3c24xx_simtec.h"
-#include "../codecs/tlv320aic3x.h"
-
static const struct snd_soc_dapm_widget dapm_widgets[] = {
SND_SOC_DAPM_LINE("GSM Out", NULL),
SND_SOC_DAPM_LINE("GSM In", NULL),
--
1.7.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers
2011-01-05 10:05 [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers Jarkko Nikula
@ 2011-01-05 11:00 ` Liam Girdwood
2011-01-05 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-01-05 11:00 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Mark Brown
On Wed, 2011-01-05 at 12:05 +0200, Jarkko Nikula wrote:
> After multi-component conversion these machine drivers don't actually need
> anything from sound/soc/codecs/tlv320aic3x.h so don't include it.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> ---
> rx51.c and n810.c compile tested but these other machine drivers seems to not
> use anything from tlv320aic3x.h either so should be safe to remove.
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers
2011-01-05 10:05 [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers Jarkko Nikula
2011-01-05 11:00 ` Liam Girdwood
@ 2011-01-05 11:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-01-05 11:29 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Liam Girdwood
On Wed, Jan 05, 2011 at 12:05:44PM +0200, Jarkko Nikula wrote:
> After multi-component conversion these machine drivers don't actually need
> anything from sound/soc/codecs/tlv320aic3x.h so don't include it.
>
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-01-05 11:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-05 10:05 [PATCH] ASoC: Remove needless inclusion of tlv320aic3x.h from machine drivers Jarkko Nikula
2011-01-05 11:00 ` Liam Girdwood
2011-01-05 11:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).