alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 07/11] ASoC: tegra: Add tegra-das driver
Date: Wed, 5 Jan 2011 23:33:38 +0000	[thread overview]
Message-ID: <20110105233338.GA5714@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0310567AC4@HQMAIL01.nvidia.com>

On Wed, Jan 05, 2011 at 03:27:17PM -0800, Stephen Warren wrote:
> Mark Brown wrote:

> > No, I don't think this should be made visible to machine drivers at all
> > - they should just see a straight through mapping from the DMA channels
> > to the ports in the first instance.

> Oh. So what should set up this 1:1 mapping then; what module should the
> DAS register writes be contained in? And later, what module should

I guess the I2S driver?

> configure the DAS with the mux configuration that is appropriate for
> the board? It seems like the machine driver is the only place with the

My suggestion would only work for very simple boards like Harmony.

> knowledge to define what the routing should be. Whether the machine driver
> calls tegra_das_* vs. some codec/mux API to set this up seems like a
> different issue to whether the machine driver or something else should
> contain this knowledge.

The end result would be that this would all be done in the application
layer, potentially dynamically.

> In the short-term, are you expecting the I2S driver to expose a CPU DAI for
> each audio controller and port? The number of audio controllers and ports
> isn't equal, and hence it wouldn't be possible to support a board using just
> port 5 since there's no controller 5 (and even audio controller 3 I think is
> SPDIF not I2S)...

Oh, hrm.  That wasn't clear from your code.  Would mapping controller n
to port n work for Harmony?

  reply	other threads:[~2011-01-05 23:33 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1292622090-21896-1-git-send-email-swarren@nvidia.com>
     [not found] ` <1292622090-21896-8-git-send-email-swarren@nvidia.com>
     [not found]   ` <20101217220029.GD25609@sirena.org.uk>
2010-12-22 18:30     ` [PATCH 07/11] ASoC: tegra: Add tegra-das driver Stephen Warren
2010-12-22 20:11       ` Mark Brown
2011-01-05 22:58         ` Stephen Warren
2011-01-05 23:18           ` Mark Brown
2011-01-05 23:27             ` Stephen Warren
2011-01-05 23:33               ` Mark Brown [this message]
2011-01-06  0:20                 ` Stephen Warren
2011-01-06  0:59                   ` Mark Brown
2011-01-06 17:46                     ` Stephen Warren
2011-01-06 21:02                       ` Mark Brown
2011-01-06 21:58                         ` Stephen Warren
2011-01-06 22:13                           ` Mark Brown
     [not found] ` <1292622090-21896-9-git-send-email-swarren@nvidia.com>
     [not found]   ` <20101217220658.GG25609@sirena.org.uk>
2010-12-22 19:03     ` [PATCH 08/11] ASoC: tegra: Add tegra-pcm driver Stephen Warren
2010-12-22 20:16       ` Mark Brown
     [not found] ` <1292622090-21896-11-git-send-email-swarren@nvidia.com>
     [not found]   ` <20101217222636.GJ25609@sirena.org.uk>
     [not found]     ` <74CDBE0F657A3D45AFBB94109FB122FF030FD7885D@HQMAIL01.nvidia.com>
     [not found]       ` <20101217230618.GA28364@sirena.org.uk>
     [not found]         ` <20101220211131.GG14986@sirena.org.uk>
2010-12-23  1:13           ` [PATCH 10/11] ASoC: tegra: Harmony machine support Stephen Warren
2010-12-23  2:19             ` Mark Brown
2011-01-03 19:39               ` Stephen Warren
2011-01-04 15:30                 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110105233338.GA5714@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).