From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default
Date: Wed, 5 Jan 2011 23:51:16 +0000 [thread overview]
Message-ID: <20110105235115.GB5714@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110105232947.GA8514@sirena.org.uk>
On Wed, Jan 05, 2011 at 11:29:47PM +0000, Mark Brown wrote:
> > So are you saying that there's a bug in this patch? Perhaps that code should
> > look like this:
> Perhaps it should, though my immediate question (without looking at the
> existing code again) is why the existing tests are being removed.
Having looked slightly further it does look like something I'd expect to
work.
More generally though what I'm trying to say is more about the approach
that's being taken here; with things like this it's generally much
better to at least have a dig into what's not working for you and have
an idea of what's going on rather than just stopping and asking. This
is normally easier all round, either you'll be able to sort stuff out
yourself or you'll be able to ask a much better question.
next prev parent reply other threads:[~2011-01-05 23:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 16:11 [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Dimitris Papastamos
2010-12-02 16:11 ` [PATCH 1/2] ASoC: soc-cache: Use reg_def_copy instead of reg_cache_default Dimitris Papastamos
2011-01-05 21:04 ` Timur Tabi
2011-01-05 23:03 ` Mark Brown
2011-01-05 23:08 ` Timur Tabi
2011-01-05 23:29 ` Mark Brown
2011-01-05 23:51 ` Mark Brown [this message]
2011-01-06 0:15 ` Tabi Timur-B04825
2011-01-06 0:34 ` Mark Brown
2011-01-06 16:26 ` Timur Tabi
2011-01-06 21:20 ` Mark Brown
2011-01-06 16:53 ` Dimitris Papastamos
2011-01-06 17:01 ` Timur Tabi
2010-12-02 16:11 ` [PATCH 2/2] ASoC: soc-core: Allow machine drivers to override compress_type Dimitris Papastamos
2010-12-03 16:14 ` [PATCH 0/2] ASoC: Override codec compress_type from the machine driver Liam Girdwood
2010-12-03 16:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110105235115.GB5714@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).