From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: cs4270: fix dynamic initialization of register cache Date: Thu, 6 Jan 2011 21:31:39 +0000 Message-ID: <20110106213139.GG8018@opensource.wolfsonmicro.com> References: <1294339968-420-1-git-send-email-timur@freescale.com> <20110106201511.GA8018@opensource.wolfsonmicro.com> <4D262B29.3010606@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 03828103807 for ; Thu, 6 Jan 2011 22:31:24 +0100 (CET) Content-Disposition: inline In-Reply-To: <4D262B29.3010606@freescale.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Timur Tabi Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Thu, Jan 06, 2011 at 02:50:49PM -0600, Timur Tabi wrote: > BTW, why does ASoC even care about the register cache, if I have to have my own > functions to read and write it? In other words, why does function > cs4270_read_reg_cache() exist at all? What is the point of having ASoC allocate > the cache if the driver has to supply functions to read and write it? If you're completely ignoring the standard cache and register I/O code (which isn't ideal) then you should't be telling the core about your cache.