alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: dp@opensource.wolfsonmicro.com, alsa-devel@alsa-project.org,
	lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: cs4270: fix dynamic initialization of register cache
Date: Thu, 6 Jan 2011 21:41:04 +0000	[thread overview]
Message-ID: <20110106214103.GH8018@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D2624EB.6060704@freescale.com>

On Thu, Jan 06, 2011 at 02:24:11PM -0600, Timur Tabi wrote:

> What do I do if there are two CS4270s in a system, and they each have different
> power-on default values for the registers?  Granted, it's a contrived example,
> but this could happen if the first CS4270 is a rev1 chip, and the second is a
> rev2 chip.

So the driver should cope with this, for example by updating the rev1
configuration to match rev2 at probe time (presumably if the change in
rev2 was important enough to introduce the change for then rev1 needs
the change anyway).

> And even if this example is contrived, it's conceivable that there can be codecs
> where the power-on defaults are set by pin configuration.  Perhaps codec #1 is
> muted by default and codec #2 isn't.

Again, do something that seems tasteful.  For example, mark the relevant
register volatile as it might get varied randomly at runtime anyway (I'm
not sure how the mute pin plays with the register value?).  Or write out
a particular value at startup.

If there really are insurmountable obstacles (I don't beleive there are)
or you're really dead set on it then teach the core about having to read
back the state from the device.

  reply	other threads:[~2011-01-06 21:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-06 18:52 [PATCH] ASoC: cs4270: fix dynamic initialization of register cache Timur Tabi
2011-01-06 20:15 ` Mark Brown
2011-01-06 20:24   ` Timur Tabi
2011-01-06 21:41     ` Mark Brown [this message]
2011-01-06 20:50   ` Timur Tabi
2011-01-06 21:31     ` Mark Brown
2011-01-06 21:35       ` Timur Tabi
2011-01-06 22:04         ` Mark Brown
2011-01-06 22:07           ` Timur Tabi
2011-01-06 22:31             ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110106214103.GH8018@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=dp@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).