From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Koul, Vinod" <vinod.koul@intel.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"Harsha, Priya" <priya.harsha@intel.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: regarding references taken on platform and codec driver modules
Date: Mon, 10 Jan 2011 19:01:54 +0000 [thread overview]
Message-ID: <20110110190154.GA11265@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <438BB0150E931F4B9CE701519A44630104C119C43D@bgsmsx502.gar.corp.intel.com>
On Thu, Jan 06, 2011 at 02:41:29PM +0530, Koul, Vinod wrote:
> This issue is on removal of soc_remove() it doesn't free up the reference if the card is not instantiated
> So in case one of the probes fails we should handle this in soc_remove in else for instantated
> if (rtd->codec->probed)
> module_put(rtd->codec->dev->driver->owner);
> if (rtd->platform->probed)
> module_put(rtd->platform->dev->driver->owner);
> for (i = 0; i < card->num_rtd; i++)
> module_put(rtd[i].cpu_dai->dev->driver->owner);
> Would this be the correct way to solve this?
Probably, yes.
next prev parent reply other threads:[~2011-01-10 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-03 11:00 regarding references taken on platform and codec driver modules Harsha, Priya
2011-01-03 15:54 ` Mark Brown
2011-01-03 16:27 ` Harsha, Priya
2011-01-03 16:35 ` Mark Brown
2011-01-03 17:56 ` Harsha, Priya
2011-01-04 15:48 ` Mark Brown
2011-01-05 6:00 ` Harsha, Priya
2011-01-05 17:19 ` Koul, Vinod
2011-01-06 9:11 ` Koul, Vinod
2011-01-10 19:01 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-03 8:26 Harsha, Priya
2011-01-03 7:09 Harsha, Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110190154.GA11265@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox