From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: soc-core: Simplify compress_type overriding functionality
Date: Tue, 11 Jan 2011 11:35:41 +0000 [thread overview]
Message-ID: <20110111113541.GD13429@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1294745773-5123-1-git-send-email-dp@opensource.wolfsonmicro.com>
On Tue, Jan 11, 2011 at 11:36:13AM +0000, Dimitris Papastamos wrote:
> if (i == card->num_configs) {
> /* no need to override the compress_type so
> * go ahead and do the standard thing */
> - ret = snd_soc_init_codec_cache(codec, 0);
> - if (ret < 0) {
> - mutex_unlock(&card->mutex);
> - return;
> - }
> - continue;
> + compress_type = 0;
> }
Even simpler would be to init compress_type to zero and remove the
check.
next prev parent reply other threads:[~2011-01-11 11:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 11:36 [PATCH] ASoC: soc-core: Simplify compress_type overriding functionality Dimitris Papastamos
2011-01-11 11:35 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-01-11 11:43 Dimitris Papastamos
2011-01-11 11:47 ` Liam Girdwood
2011-01-11 18:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110111113541.GD13429@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).