Re: [PATCH] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Fri, Jan 14, 2011 at 09:43:04AM +0200, Matti J. Aaltonen wrote:
> On Thu, 2011-01-13 at 17:12 +0000, ext Mark Brown 

> > This is something that should really have been brought up when making
> > changes.  It's really bad to just go and make other bits of the kernel
> > fail to build.

> I'm not exactly sure what you mean here... It's easy to say now - when
> looking back that - the whole driver should have been handled more as a
> whole. An ACK from you and an ACK from Samuel to the media guys etc...

If you're making an incompatible change in an API used by code that is
already part of the kernel then you need to make sure that that code is
updated as part of introducing the new API.

> > While looking at this I also notice that it's surprisingly difficult to
> > actually build any of this stuff - the MFD core can't be enabled
> > directly, it's only available if you enable the V4L driver, and the core
> > V4L build appears to be rather large adding a noticable amount of time
> > to the build needed to get coverage of the CODECs.  It'd be good if you
> > could fix this to remove the dependency, I'd really expect the MFD to be
> > able to build by itself.

> The codec can already be built alone, I can't see what benefit would
> building the empty MFD driver offer. With the current structure nothing
> can actually be done without the V4L2 driver. But if there's something I
> don't get right now, I'll be happy make changes.

As things stand the only way the CODEC driver can be built is if V4L is
enabled, which like I say isn't a trivial build.  This isn't ideal when
trying to get build coverage of the CODEC drivers for work on the core,
it adds noticable additional delay.