From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: Misael Lopez Cruz <misael.lopez@ti.com>,
alsa-deve@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: dapm: Fix race condition in widgets power list creation
Date: Tue, 18 Jan 2011 11:39:56 +0000 [thread overview]
Message-ID: <20110118113956.GE26498@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D357B09.70505@nokia.com>
On Tue, Jan 18, 2011 at 01:35:37PM +0200, Peter Ujfalusi wrote:
> Hmm, the patch looks quite similar to the patch I've sent back in November:
> http://mailman.alsa-project.org/pipermail/alsa-devel/2010-November/033362.html
My thought exactly.
> On 01/18/11 12:39, ext Mark Brown wrote:
> > This needs a bit more analysis - why are we getting multiple
> > simultaneous calls to dapm_power_widgets() and is that itself safe? The
> > ASoC locking model has always been to have a big lock around the entire
> > card rather than to lock subcomponents, and for example this isn't going
> > to make sure we're consistent with register map accesses from other
> > parts of the code.
> As far as I have traced back than, it was due to the use of dapm_sync in
> machine drivers. For me it looked that all other paths were satisfactory
> protected.
> In my case the use of SOC_DAPM_PIN_SWITCH() instead of the custom call
> fixed the race (since this will take a card mutex, AFAIK).
I *suspect* that we're in a similar case and either the locking has been
broken by the multi-component stuff or there's other cases that need
protection, probably the jack detection code.
> PS: I might received this mail unintentionally, since I was not on the
> TO/CC, and alsa-devel neither.
> Should alsa-devel be on the CC?
Yes, I bounced on the second copy - Misael had sent two copies of the
mail, one omitting the CC, and I'd replied to the first one before I saw
the second.
next prev parent reply other threads:[~2011-01-18 11:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1295318127-17968-1-git-send-email-misael.lopez@ti.com>
2011-01-18 10:39 ` [PATCH] ASoC: dapm: Fix race condition in widgets power list creation Mark Brown
[not found] ` <4D357B09.70505@nokia.com>
2011-01-18 11:39 ` Mark Brown [this message]
2011-01-18 12:08 ` Peter Ujfalusi
2011-01-18 12:26 ` Mark Brown
2011-01-18 12:47 ` Peter Ujfalusi
2011-01-18 13:21 ` Jarkko Nikula
2011-01-18 13:23 ` Mark Brown
2011-01-18 12:34 ` Peter Ujfalusi
2011-01-18 13:22 ` Mark Brown
2011-01-18 2:36 Misael Lopez Cruz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110118113956.GE26498@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-deve@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=misael.lopez@ti.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).