alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: PXA: Fix codec address on Zipit Z2
Date: Tue, 18 Jan 2011 16:05:47 +0100	[thread overview]
Message-ID: <201101181605.47580.marek.vasut@gmail.com> (raw)
In-Reply-To: <1295362465-21794-2-git-send-email-anarsoul@gmail.com>

On Tuesday 18 January 2011 15:54:25 Vasily Khoruzhick wrote:
> WM8750 address is 0x1b, not 0x1a. Without this fix
> ALSA detects no sound cards on Zipit
> 
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
>  sound/soc/pxa/z2.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sound/soc/pxa/z2.c b/sound/soc/pxa/z2.c
> index 0da889d..62c77dc 100644
> --- a/sound/soc/pxa/z2.c
> +++ b/sound/soc/pxa/z2.c
> @@ -193,7 +193,7 @@ static struct snd_soc_dai_link z2_dai = {
>  	.cpu_dai_name	= "pxa2xx-i2s",
>  	.codec_dai_name	= "wm8750-hifi",
>  	.platform_name = "pxa-pcm-audio",
> -	.codec_name	= "wm8750-codec.0-001a",
> +	.codec_name	= "wm8750-codec.0-001b",
>  	.init		= z2_wm8750_init,
>  	.ops		= &z2_ops,
>  };

Acked-by: Marek Vasut <marek.vasut@gmail.com>

Mark, shall I/Eric pick it via pxa-linux-2.6 or are you taking care of these two 
?

  reply	other threads:[~2011-01-18 15:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 14:54 [PATCH 1/2] ASoC: PXA: Fix jack detection on Zipit Z2 Vasily Khoruzhick
2011-01-18 14:54 ` [PATCH 2/2] ASoC: PXA: Fix codec address " Vasily Khoruzhick
2011-01-18 15:05   ` Marek Vasut [this message]
2011-01-18 15:07     ` Mark Brown
2011-01-18 15:09 ` [PATCH 1/2] ASoC: PXA: Fix jack detection " Liam Girdwood
2011-01-18 19:01   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201101181605.47580.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anarsoul@gmail.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).