* [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init
@ 2011-01-18 13:51 Peter Ujfalusi
2011-01-18 14:22 ` Jarkko Nikula
2011-01-18 19:10 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Peter Ujfalusi @ 2011-01-18 13:51 UTC (permalink / raw)
To: alsa-devel; +Cc: Mark Brown, Liam Girdwood
snd_soc_dapm_new_widgets will call dapm_power_widgets at
the end, so there is no need to call snd_soc_dapm_sync
after snd_soc_dapm_new_widgets.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
sound/soc/soc-core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index bac7291..952f104 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1467,7 +1467,6 @@ static int soc_post_component_init(struct snd_soc_card *card,
/* Make sure all DAPM widgets are instantiated */
snd_soc_dapm_new_widgets(&codec->dapm);
- snd_soc_dapm_sync(&codec->dapm);
/* register the rtd device */
rtd->codec = codec;
--
1.7.4.rc2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init
2011-01-18 13:51 [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init Peter Ujfalusi
@ 2011-01-18 14:22 ` Jarkko Nikula
2011-01-18 14:44 ` Liam Girdwood
2011-01-18 19:10 ` Mark Brown
1 sibling, 1 reply; 4+ messages in thread
From: Jarkko Nikula @ 2011-01-18 14:22 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Mark Brown, Liam Girdwood
On Tue, 18 Jan 2011 15:51:45 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> snd_soc_dapm_new_widgets will call dapm_power_widgets at
> the end, so there is no need to call snd_soc_dapm_sync
> after snd_soc_dapm_new_widgets.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
> sound/soc/soc-core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
fwiw,
Reviewed-by: Jarkko Nikula <jhnikula@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init
2011-01-18 14:22 ` Jarkko Nikula
@ 2011-01-18 14:44 ` Liam Girdwood
0 siblings, 0 replies; 4+ messages in thread
From: Liam Girdwood @ 2011-01-18 14:44 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: alsa-devel, Mark Brown, Peter Ujfalusi
On Tue, 2011-01-18 at 16:22 +0200, Jarkko Nikula wrote:
> On Tue, 18 Jan 2011 15:51:45 +0200
> Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
>
> > snd_soc_dapm_new_widgets will call dapm_power_widgets at
> > the end, so there is no need to call snd_soc_dapm_sync
> > after snd_soc_dapm_new_widgets.
> >
> > Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> > ---
> > sound/soc/soc-core.c | 1 -
> > 1 files changed, 0 insertions(+), 1 deletions(-)
> >
> fwiw,
>
> Reviewed-by: Jarkko Nikula <jhnikula@gmail.com
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init
2011-01-18 13:51 [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init Peter Ujfalusi
2011-01-18 14:22 ` Jarkko Nikula
@ 2011-01-18 19:10 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2011-01-18 19:10 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood
On Tue, Jan 18, 2011 at 03:51:45PM +0200, Peter Ujfalusi wrote:
> snd_soc_dapm_new_widgets will call dapm_power_widgets at
> the end, so there is no need to call snd_soc_dapm_sync
> after snd_soc_dapm_new_widgets.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-18 19:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-18 13:51 [PATCH] ASoC: core: Remove dapm_sync call from soc_post_component_init Peter Ujfalusi
2011-01-18 14:22 ` Jarkko Nikula
2011-01-18 14:44 ` Liam Girdwood
2011-01-18 19:10 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).