From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/3] ASoC: Add support for sequencing within
Date: Wed, 19 Jan 2011 10:07:51 +0000 [thread overview]
Message-ID: <20110119100751.GA16288@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D369E9A.1030501@nokia.com>
On Wed, Jan 19, 2011 at 10:19:38AM +0200, Peter Ujfalusi wrote:
> I have been wondering, if we just go, and follow the sequence of the
> DAPM widgets in on the path on powerup, and follow the reverse sequence
> on powerdown.
It's certainly worth considering. It's not unambiguously clear that
this is ideal - there's a few cases where you pretty much always want to
do things in a different order to the straight path, the primary one
being that since PGAs make everything more noisy you generally want to
power them on last. There's also the issue that you don't want to
oversequence things, more often than not bringing things up in parallel
performs at least as well or even better.
> IMHO in this way we would have better control over the sequences, and we
> might be in better position to combat pop noises, since we have more
> explicit control over the sequence of events.
OOI, do we actually have issues here at the minute? The only issue I'm
aware of is that we don't have a facility for keeping PGAs muted while
sequences are running.
> I have not looked how hard it would be to change the DAPM to do this.
> Anyways I would not started to do this without asking... I know there
> are really good reasons to have the current DAPM sequence handling, but
> I do wonder, if it make sense to do this.
It's potentially useful. There are some considerations as above that
mean we don't want a straight graph walk but there's certainly some room
for using the infrastructure.
next prev parent reply other threads:[~2011-01-19 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-18 16:20 [PATCH 1/3] ASoC: Explicitly say if we're powering up or down Mark Brown
2011-01-18 16:20 ` [PATCH 2/3] ASoC: Add support for sequencing within Mark Brown
2011-01-19 8:19 ` Peter Ujfalusi
2011-01-19 10:07 ` Mark Brown [this message]
2011-01-18 16:20 ` [PATCH 3/3] ASoC: Provide per widget type callback when executing DAPM sequences Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119100751.GA16288@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).