From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Harsha Priya <priya.harsha@intel.com>
Cc: tiwai@suse.de, Vinod Koul <vinod.koul@intel.com>,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/4] ASoC: mid-x86: Add support for capture in machine driver
Date: Wed, 19 Jan 2011 14:24:23 +0000 [thread overview]
Message-ID: <20110119142423.GA16328@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1295441221-32132-1-git-send-email-priya.harsha@intel.com>
On Wed, Jan 19, 2011 at 06:17:01PM +0530, Harsha Priya wrote:
> + /* we are using DMICs here so configure how the clock and out pin is set */
> + snd_soc_write(codec, SN95031_DMICBUF0123, 0x85);
> + snd_soc_write(codec, SN95031_DMICBUF45, 0x02);
> + snd_soc_update_bits(codec, SN95031_DMICMUX, 0x7, 0x07);
This looks like something which would more normally be done with
platform data than with writes in the machine driver.
next prev parent reply other threads:[~2011-01-19 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-19 12:47 [PATCH 3/4] ASoC: mid-x86: Add support for capture in machine driver Harsha Priya
2011-01-19 14:24 ` Mark Brown [this message]
2011-01-19 16:29 ` Koul, Vinod
2011-01-19 16:36 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-01-19 12:48 Harsha Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110119142423.GA16328@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).