From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: snd_soc_jack_add_gpios vs. SOC_DAPM_PIN_SWITCH
Date: Tue, 1 Feb 2011 11:33:51 +0000 [thread overview]
Message-ID: <20110201113351.GB12743@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0310C8E333@HQMAIL01.nvidia.com>
On Mon, Jan 31, 2011 at 04:03:58PM -0800, Stephen Warren wrote:
> However, if I use the control to disable the headphones, then unplug/replug
> the headphones, the jack detect seems to override the control, and I hear
> audio from the headphones.
> Is this something that's known not yet implemented or was never intended to
> be used this way, or should I look further to find the issue?
Using these two together makes no sense. Either you manually control
the state of the output or you manage it automatically.
Generally a PIN_SWITCH() should only be used to offer control if none is
availabile within the CODEC - in the case of Harmony it wouldn't make
much sense as there's plenty of control in the CODEC for what gets
routed to the various outputs.
> FYI, sound/soc/samsung/smartq_wm8987.c has this same code structure, and I
> imagine will have the same issue.
Probably.
next prev parent reply other threads:[~2011-02-01 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 0:03 snd_soc_jack_add_gpios vs. SOC_DAPM_PIN_SWITCH Stephen Warren
2011-02-01 11:33 ` Mark Brown [this message]
2011-02-01 18:59 ` Stephen Warren
2011-02-01 22:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201113351.GB12743@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).