From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Harsha, Priya" <priya.harsha@intel.com>
Cc: "Koul, Vinod" <vinod.koul@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/3] ASoC: soc_jack - add function to determine jack type
Date: Tue, 1 Feb 2011 13:43:53 +0000 [thread overview]
Message-ID: <20110201134352.GF12743@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <98769532B4BB14429434178695419EAE08C0FE9A6C@bgsmsx501.gar.corp.intel.com>
On Tue, Feb 01, 2011 at 07:05:26PM +0530, Harsha, Priya wrote:
Please fix the word wrapping in your MUA to wrap at less than 80
columns.
> What if I add a field debouce to snd_soc_jack and machine driver needs
> to program the value. The codec driver should wait for that time
> before reading the adc values Will this help
The driver providing the ADC (which may not be part of a CODEC at all)
shouldn't have to worry about this stuff unless it's done the
debouncing - we should avoid having to open code functionality in
individual drivers. It feels like we should have actual code for
managing the process of detecting what's connected, with flexibility to
handle things like pre-debouncing. If some of it is left sketchy in the
first instance that's OK but we should have an idea what the overall
picture is.
prev parent reply other threads:[~2011-02-01 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-28 17:09 [PATCH 1/3] ASoC: soc_jack - add function to determine jack type Harsha Priya
2011-01-31 12:06 ` Liam Girdwood
2011-01-31 12:08 ` Mark Brown
2011-02-01 13:19 ` Harsha, Priya
2011-02-01 13:22 ` Mark Brown
2011-02-01 13:35 ` Harsha, Priya
2011-02-01 13:43 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201134352.GF12743@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).