From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] EDB93xx: Add support for CS4271 CODEC on EDB93xx boards Date: Wed, 2 Feb 2011 17:00:00 +0000 Message-ID: <20110202165959.GT12743@opensource.wolfsonmicro.com> References: <1296603653.1504.9.camel@r60e> <0D753D10438DA54287A00B027084269764CEF59B2B@AUSP01VMBX24.collaborationhost.net> <1296643688.1504.23.camel@r60e> <20110202104943.GN12743@opensource.wolfsonmicro.com> <1296645167.1504.31.camel@r60e> <20110202125327.GO12743@opensource.wolfsonmicro.com> <1296653211.1504.40.camel@r60e> <0D753D10438DA54287A00B027084269764CEFD45C8@AUSP01VMBX24.collaborationhost.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 991B0103A21 for ; Wed, 2 Feb 2011 18:00:01 +0100 (CET) Content-Disposition: inline In-Reply-To: <0D753D10438DA54287A00B027084269764CEFD45C8@AUSP01VMBX24.collaborationhost.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: H Hartley Sweeten Cc: Dimitris Papastamos , "alsa-devel@alsa-project.org" , Alexander Sverdlin , "linux-arm-kernel@lists.infradead.org" , Lennert Buytenhek , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Wed, Feb 02, 2011 at 10:53:15AM -0600, H Hartley Sweeten wrote: > I don't have any problem with leaving the reset management in the codec. > The enable (chip-select) should be handled in the platform code. But, > gpio_disable should be removed from struct cs4271_platform_data to avoid > any confusion. Is that really a chip select or is it a power control?