Re: WL1273 FM Radio driver...

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Mauro,

On Wed, Feb 02, 2011 at 01:35:01PM -0200, Mauro Carvalho Chehab wrote:
> Em 30-01-2011 21:23, Samuel Ortiz escreveu:
> > Hi Matti,
> > 
> > On Tue, Jan 18, 2011 at 05:04:23PM +0200, Matti J. Aaltonen wrote:
> >> Hello
> >>
> >> I have been trying to get the WL1273 FM radio driver into the kernel for
> >> some time. It has been kind of difficult, one of the reasons is that I
> >> didn't realize I should have tried to involve all relevant maintainers
> >> to the discussion form the beginning (AsoC, Media and MFD). At Mark's
> >> suggestion I'm trying to reopen the discussion now.
> >>
> >> The driver consists of an MFD core and two child drivers (the audio
> >> codec and the V4L2 driver). And the question is mainly about the role of
> >> the MFD driver: the original design had the IO functions in the core.
> >> Currently the core is practically empty mainly because Mauro very
> >> strongly wanted to have “everything” in the V4L2 driver.
> > What was Mauro main concerns with having the IO part in the core ?
> > A lot of MFD drivers are going that path already.
> 
> My concerns is that the V4L2-specific part of the code should be at drivers/media.
> I prefer that the specific MFD I/O part to be at drivers/mfd, just like
> the other drivers.
Agreed, but it seems that's not the case currently. Would you be ok with Matti
refactoring those 2 drivers a bit so that the actual core I/O parts should be
handled by the MFD driver ?

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/