From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/6] ASoC: Tegra: Harmony: Add headphone jack detection Date: Thu, 3 Feb 2011 22:35:31 +0000 Message-ID: <20110203223530.GA4586@opensource.wolfsonmicro.com> References: <1296766578-13988-1-git-send-email-swarren@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1296766578-13988-1-git-send-email-swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: lrg-kDsPt+C1G03kYMGBc/C6ZA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: alsa-devel@alsa-project.org On Thu, Feb 03, 2011 at 01:56:13PM -0700, Stephen Warren wrote: > +static struct snd_soc_jack harmony_hp_jack; > + Since you've changed to using a platform device you should really be dynamically allocating this I guess. But this isn't actually a practical problem so not worth caring about. -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html