From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Harsha, Priya" <priya.harsha@intel.com>
Cc: "Koul, Vinod" <vinod.koul@intel.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 3/3] ASoC: sn95031 codec - adding jack detection/reporting
Date: Fri, 4 Feb 2011 14:05:05 +0000 [thread overview]
Message-ID: <20110204140504.GA5393@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <98769532B4BB14429434178695419EAE08C107FB23@bgsmsx501.gar.corp.intel.com>
On Fri, Feb 04, 2011 at 09:20:52AM +0530, Harsha, Priya wrote:
> >By the way, this logic for reporting the buttons separately to the
> >detection of the headset/headphone status is something that should be
> >pulled out into generic code as the same mechanism is going to be needed
> >by anything using voltage based detection.
> But here, we don't do button press detection based on voltage. We get a
> separate value being set in register when interrupt is generated. In the
> generic code of adding zones and retrieving type, we can add the button press.
Right, but one common way of doing multiple buttons is to use the
detection of the short to trigger an ADC reading and then look at the
value.
next prev parent reply other threads:[~2011-02-04 14:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 11:26 [PATCH 3/3] ASoC: sn95031 codec - adding jack detection/reporting Harsha Priya
2011-02-03 16:06 ` Mark Brown
2011-02-03 23:03 ` Mark Brown
2011-02-04 3:50 ` Harsha, Priya
2011-02-04 14:05 ` Mark Brown [this message]
2011-02-04 5:49 ` Harsha, Priya
2011-02-04 14:10 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2011-01-28 17:11 Harsha Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110204140504.GA5393@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=priya.harsha@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).