From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration
Date: Mon, 7 Feb 2011 17:02:14 +0000 [thread overview]
Message-ID: <20110207170213.GP10564@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D5023A4.3020209@metafoo.de>
Please fix your MUA to word wrap at less than 80 columns, I've reflowed
your text so it's legible.
On Mon, Feb 07, 2011 at 05:53:56PM +0100, Lars-Peter Clausen wrote:
> > In any
> > case, we clearly shouldn't be applying patches which bodge around the
> > core.
> Well the alternative would be a patch looking like this:
> - .cpu_dai_name = "bluetooth-dai",
> + .cpu_dai_name = "soc-core",
> Which isn't really nice either.
If you think the core isn't behaving helpfully the core should be
changed. This is part of how APIs evolve to be maximally useful.
To be honest it's not massively obvious that we shouldn't just be taking
the name of the device here, either using a device to represent the
modem or registering the card using snd_soc_register_machine() and using
a more meaningful name for the card seems like a sensible approach here.
next prev parent reply other threads:[~2011-02-07 17:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 23:04 [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 2/7] ASoC: neo1973_wm8753: Move lm4857 specefic code to its own module Lars-Peter Clausen
2011-02-07 11:50 ` Mark Brown
2011-02-06 23:04 ` [PATCH 3/7] ASoC: codecs: lm4857: Use dev_pm_ops Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 4/7] ASoC: neo1973_gta02_wm8753: Remove lm4853_{set,get}_state Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 5/7] ASoC: Samsung: neo1973: Use gpio_request_array to request gpios Lars-Peter Clausen
2011-02-06 23:04 ` [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration Lars-Peter Clausen
2011-02-07 11:59 ` Mark Brown
2011-02-07 16:53 ` Lars-Peter Clausen
2011-02-07 17:02 ` Mark Brown [this message]
2011-02-07 17:37 ` Lars-Peter Clausen
2011-02-07 17:49 ` Mark Brown
2011-02-07 18:09 ` Lars-Peter Clausen
2011-02-07 18:17 ` Mark Brown
2011-02-07 22:55 ` Adding bluetooth PCM interface support to ASoC (Was: Re: [PATCH 6/7] ASoC: Samsung: neo1973_gta02: Fix bluetooth DAI registration) Lars-Peter Clausen
2011-02-08 13:08 ` Mark Brown
2011-02-06 23:04 ` [PATCH 7/7] ASoC: Samsung: Merge neo1937 and neo1973_gta02 sound board driver Lars-Peter Clausen
2011-02-07 2:25 ` [alsa-devel] [PATCH 1/7] ASoC: neo1973_wm8753: Remove scenario management code Jassi Brar
2011-02-07 11:42 ` Mark Brown
2011-02-07 17:01 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110207170213.GP10564@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).