Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2 2.6.38] ASoC: soc-cache: Introduce the	cache_bypass option
Date: Fri, 11 Feb 2011 15:46:54 +0000	[thread overview]
Message-ID: <20110211154654.GA32441@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110211151825.GA23687@opensource.wolfsonmicro.com>

On Fri, Feb 11, 2011 at 03:18:26PM +0000, Mark Brown wrote:
> On Fri, Feb 11, 2011 at 02:54:01PM +0000, Dimitris Papastamos wrote:
> > This is primarily needed to avoid writing back to the cache
> > whenever we are syncing the cache with the hardware.  This gives a
> > performance benefit especially for large register maps.
> 
> Hrm, this is a rather large and invasive patch to be applying as part of
> a bug fix for a specific driver this late in the release process.  Can
> we do something driver specific for the 2.6.38 release?

Would this be acceptable?  In wm8994_resume():

/* force a HW read */
val = wm8994_reg_read(codec->control_data, WM8994_POWER_MANAGEMENT_5);

instead of the call to snd_soc_read().

Thanks,
Dimitris

  parent reply	other threads:[~2011-02-11 15:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-11 14:54 [PATCH 1/2 2.6.38] ASoC: soc-cache: Introduce the cache_bypass option Dimitris Papastamos
2011-02-11 14:54 ` [PATCH 2/2 2.6.38] ASoC: soc-cache: Apply " Dimitris Papastamos
2011-02-11 15:18 ` [PATCH 1/2 2.6.38] ASoC: soc-cache: Introduce " Mark Brown
2011-02-11 15:21   ` Dimitris Papastamos
2011-02-11 15:30     ` Dimitris Papastamos
2011-02-11 15:46   ` Dimitris Papastamos [this message]
2011-02-11 17:54     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110211154654.GA32441@opensource.wolfsonmicro.com \
    --to=dp@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    --cc=patches@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox