alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries
@ 2011-02-24 17:09 Dimitris Papastamos
  2011-02-25  9:01 ` Liam Girdwood
  2011-02-25 11:52 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Dimitris Papastamos @ 2011-02-24 17:09 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, patches

Sometimes the name of the control switch of a dapm route contains
spaces which makes it impossible to distinguish it from the source widget.
Add quotes around the names of the widgets to makes these parsable.

Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
---
 sound/soc/soc-dapm.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index 200ae7c..b8e6ab7 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -1242,7 +1242,7 @@ static ssize_t dapm_widget_power_read_file(struct file *file,
 
 		if (p->connect)
 			ret += snprintf(buf + ret, PAGE_SIZE - ret,
-					" in  %s %s\n",
+					" in  \"%s\" \"%s\"\n",
 					p->name ? p->name : "static",
 					p->source->name);
 	}
@@ -1252,7 +1252,7 @@ static ssize_t dapm_widget_power_read_file(struct file *file,
 
 		if (p->connect)
 			ret += snprintf(buf + ret, PAGE_SIZE - ret,
-					" out %s %s\n",
+					" out \"%s\" \"%s\"\n",
 					p->name ? p->name : "static",
 					p->sink->name);
 	}
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries
  2011-02-24 17:09 [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries Dimitris Papastamos
@ 2011-02-25  9:01 ` Liam Girdwood
  2011-02-25 11:52 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-02-25  9:01 UTC (permalink / raw)
  To: Dimitris Papastamos; +Cc: alsa-devel, Mark Brown, patches

On Thu, 2011-02-24 at 17:09 +0000, Dimitris Papastamos wrote:
> Sometimes the name of the control switch of a dapm route contains
> spaces which makes it impossible to distinguish it from the source widget.
> Add quotes around the names of the widgets to makes these parsable.
> 
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
> ---

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries
  2011-02-24 17:09 [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries Dimitris Papastamos
  2011-02-25  9:01 ` Liam Girdwood
@ 2011-02-25 11:52 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-02-25 11:52 UTC (permalink / raw)
  To: Dimitris Papastamos; +Cc: alsa-devel, patches, Liam Girdwood

On Thu, Feb 24, 2011 at 05:09:32PM +0000, Dimitris Papastamos wrote:
> Sometimes the name of the control switch of a dapm route contains
> spaces which makes it impossible to distinguish it from the source widget.
> Add quotes around the names of the widgets to makes these parsable.
> 
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-25 11:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-24 17:09 [PATCH] ASoC: soc-dapm: Include quotes around contents in debugfs entries Dimitris Papastamos
2011-02-25  9:01 ` Liam Girdwood
2011-02-25 11:52 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).