From: Samuel Ortiz <sameo@linux.intel.com>
To: "Matti J. Aaltonen" <matti.j.aaltonen@nokia.com>
Cc: ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, lrg@slimlogic.co.uk,
mchehab@redhat.com, hverkuil@xs4all.nl,
linux-media@vger.kernel.org
Subject: Re: [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers.
Date: Tue, 1 Mar 2011 14:50:41 +0100 [thread overview]
Message-ID: <20110301135040.GB4543@sortiz-mobl> (raw)
In-Reply-To: <1298987085.29371.123.camel@masi.mnp.nokia.com>
On Tue, Mar 01, 2011 at 03:44:45PM +0200, Matti J. Aaltonen wrote:
> On Tue, 2011-03-01 at 13:23 +0000, ext Mark Brown wrote:
> > On Tue, Mar 01, 2011 at 03:10:37PM +0200, Matti J. Aaltonen wrote:
> > > These changes are needed to keep up with the changes in the
> > > MFD core and V4L2 parts of the wl1273 FM radio driver.
> > >
> > > Use function pointers instead of exported functions for I2C IO.
> > > Also move all preprocessor constants from the wl1273.h to
> > > include/linux/mfd/wl1273-core.h.
> > >
> > > Also update the year in the copyright statement.
> > >
> > > Signed-off-by: Matti J. Aaltonen <matti.j.aaltonen@nokia.com>
> >
> > Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> >
> > *Please* keep acks unless you're making substantial changes to
> > repostings.
>
> OK, I see, I should have added the ACKs to the relevant driver files
> instead of copying them to the cover letter...
Yes, it makes it easier for the maintainer taking your patches.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2011-03-01 13:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 13:10 [PATCH v22 0/3] ASoC/MFD/V4L2: WL1273 FM Radio Driver Matti J. Aaltonen
2011-03-01 13:10 ` [PATCH v22 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio Matti J. Aaltonen
2011-03-01 13:10 ` [PATCH v22 2/3] V4L2: WL1273 FM Radio: TI WL1273 FM radio driver Matti J. Aaltonen
2011-03-01 13:10 ` [PATCH v22 3/3] ASoC: WL1273 FM radio: Access I2C IO functions through pointers Matti J. Aaltonen
2011-03-01 13:23 ` Mark Brown
2011-03-01 13:44 ` Matti J. Aaltonen
2011-03-01 13:50 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301135040.GB4543@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=matti.j.aaltonen@nokia.com \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).