alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Timur Tabi <timur@freescale.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
	Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Remove module probe announcements from CODEC drivers
Date: Tue, 1 Mar 2011 20:21:54 +0000	[thread overview]
Message-ID: <20110301202153.GJ9662@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D6D5445.3010202@freescale.com>

On Tue, Mar 01, 2011 at 02:17:09PM -0600, Timur Tabi wrote:

> Can I get a justification for this change?  On my boards, the CS4270 driver is
> compiled in-kernel, not as a module, and so when the kernel boots, the driver
> announces itself when it's loaded.  I like this a lot, which is why I always put
> a pr_info() in the __init function of my modules.

It's rather chatty, especially where one has unused modules compiled
into the kernel, and displayed on the (usually slow serial) console by
default.  Having lots of drivers announce themselves in this fashion
gets rather spammy, at the minute only a very small proportion do so.
As a matter of policy Linux drivers generally don't do this.

Printing a message when the driver is actually binding to hardware can
be useful, mainly if it's something like announcing the device revision,
but doing so at module load isn't really conveying anything meaningful.

  reply	other threads:[~2011-03-01 20:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-01 20:14 [PATCH] ASoC: Remove module probe announcements from CODEC drivers Mark Brown
2011-03-01 20:17 ` Timur Tabi
2011-03-01 20:21   ` Mark Brown [this message]
2011-03-01 20:57 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110301202153.GJ9662@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=patches@opensource.wolfsonmicro.com \
    --cc=timur@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).