From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Javier Martin <javier.martin@vista-silicon.com>
Cc: alsa-devel@alsa-project.org, b32542@freescale.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH v3] ASoC: Add TI tlv320aic32x4 codec support.
Date: Fri, 4 Mar 2011 18:24:03 +0000 [thread overview]
Message-ID: <20110304182402.GA11930@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1299073952-11768-1-git-send-email-javier.martin@vista-silicon.com>
On Wed, Mar 02, 2011 at 02:52:32PM +0100, Javier Martin wrote:
> This patch adds support for tlv320aic3205 and tlv320aic3254 codecs.
> It doesn't include miniDSP support for aic3254.
>
> Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
I've applied this, thanks.
One thing which can be dealt with incrementally:
> + /* Do DACs need to be swapped? */
> + if (aic32x4->swapdacs) {
> + snd_soc_write(codec, AIC32X4_DACSETUP, AIC32X4_LDAC2RCHN | AIC32X4_RDAC2LCHN);
> + } else {
> + snd_soc_write(codec, AIC32X4_DACSETUP, AIC32X4_LDAC2LCHN | AIC32X4_RDAC2RCHN);
> + }
These should be runtime controlled: in the cases where you use it to get
a mic channel from left to right or vice versa you often have two mics
you need to swap between rather than a single static configuration (eg,
built in plus headset).
prev parent reply other threads:[~2011-03-04 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 13:52 [PATCH v3] ASoC: Add TI tlv320aic32x4 codec support Javier Martin
2011-03-03 10:29 ` Liam Girdwood
2011-03-04 18:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304182402.GA11930@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=b32542@freescale.com \
--cc=javier.martin@vista-silicon.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).