From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Seungwhan Youn <claude.youn@gmail.com>
Cc: Christian Glindkamp <christian.glindkamp@taskit.de>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Add MAX9850 codec driver
Date: Tue, 8 Mar 2011 10:21:45 +0000 [thread overview]
Message-ID: <20110308102145.GB11205@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTikYd7+WXa1jcse=VG1YxyX52JM1Z6y-khCwZJ-R@mail.gmail.com>
On Tue, Mar 08, 2011 at 01:40:05AM +0900, Seungwhan Youn wrote:
> IMHO, because of MAX9850_* macros are only using inside max9850.c, I
> think that move MAX9850_* macros into max9850.c and remove max9850.h
> header file, is more looks good to me.
It is common practice to have the register definitions / enumerations in
a header file even though they are only used by 1 driver. However, any
other type declarations or definitions which are not used by multiple
drivers are never put into the header file.
Thanks,
Dimitris
next prev parent reply other threads:[~2011-03-08 10:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 12:45 [PATCH] ASoC: Add MAX9850 codec driver Christian Glindkamp
2011-03-07 13:48 ` Dimitris Papastamos
2011-03-07 17:04 ` Christian Glindkamp
2011-03-07 17:14 ` Mark Brown
2011-03-08 10:14 ` Dimitris Papastamos
2011-03-08 11:52 ` Christian Glindkamp
2011-03-08 12:09 ` Dimitris Papastamos
2011-03-07 15:15 ` Mark Brown
2011-03-08 9:51 ` Christian Glindkamp
2011-03-07 16:40 ` Seungwhan Youn
2011-03-08 10:21 ` Dimitris Papastamos [this message]
2011-03-09 10:20 ` [PATCH v2] " Christian Glindkamp
2011-03-09 14:31 ` Dimitris Papastamos
2011-03-11 11:06 ` Liam Girdwood
2011-03-11 12:09 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308102145.GB11205@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=christian.glindkamp@taskit.de \
--cc=claude.youn@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).