From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dimitris Papastamos Subject: Re: [PATCH] ASoC: Add MAX9850 codec driver Date: Tue, 8 Mar 2011 10:21:45 +0000 Message-ID: <20110308102145.GB11205@opensource.wolfsonmicro.com> References: <1299501913-3772-1-git-send-email-christian.glindkamp@taskit.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 6017B10383E for ; Tue, 8 Mar 2011 11:21:48 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Seungwhan Youn Cc: Christian Glindkamp , Mark Brown , alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, Mar 08, 2011 at 01:40:05AM +0900, Seungwhan Youn wrote: > IMHO, because of MAX9850_* macros are only using inside max9850.c, I > think that move MAX9850_* macros into max9850.c and remove max9850.h > header file, is more looks good to me. It is common practice to have the register definitions / enumerations in a header file even though they are only used by 1 driver. However, any other type declarations or definitions which are not used by multiple drivers are never put into the header file. Thanks, Dimitris