From: Jarkko Nikula <jhnikula@gmail.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Ujfalusi <peter.ujfalusi@nokia.com>,
patches@opensource.wolfsonmicro.com, Peter@alsa-project.org
Subject: Re: [PATCH] ASoC: Fix prefixing of DAPM controls by factoring prefix into snd_soc_cnew()
Date: Wed, 9 Mar 2011 10:19:51 +0200 [thread overview]
Message-ID: <20110309101951.18c804f5.jhnikula@gmail.com> (raw)
In-Reply-To: <1299607281.3374.13.camel@odin>
On Tue, 08 Mar 2011 18:01:21 +0000
Liam Girdwood <lrg@slimlogic.co.uk> wrote:
> On Tue, 2011-03-08 at 17:25 +0000, Mark Brown wrote:
> > Currently will ignore prefixes when creating DAPM controls. Since currently
> > all control creation goes through snd_soc_cnew() we can fix this by factoring
> > the prefixing into that function.
> >
> > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> Acked-by: Liam Girdwood <lrg@ti.com>
>
Unfortunately this leads to double prefixing to mixer and mux controls
on Nokia RX-51/N900 in today's head. Reason there is that the
snd_soc_dapm_new_control has already added the prefix to widget name
and the dapm_new_mixer/mux takes this prefixed w->name and prefixes it
again.
codec driver or soc_probe_codec
-> snd_soc_dapm_new_controls
-> snd_soc_dapm_new_control: prefix added to w->name
soc_post_component_init
-> snd_soc_dapm_new_widgets
-> dapm_new_mixer/mux: prefix added again to w->name
--
Jarkko
next prev parent reply other threads:[~2011-03-09 8:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 17:25 [PATCH] ASoC: Fix prefixing of DAPM controls by factoring prefix into snd_soc_cnew() Mark Brown
2011-03-08 18:01 ` Liam Girdwood
2011-03-09 8:19 ` Jarkko Nikula [this message]
2011-03-09 11:03 ` Mark Brown
2011-03-09 11:35 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309101951.18c804f5.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=Peter@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=patches@opensource.wolfsonmicro.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).