* [PATCH -next] soc: sgtl5000 uses regulator interfaces [not found] <20110304180027.20deb6c4.sfr@canb.auug.org.au> @ 2011-03-05 1:33 ` Randy Dunlap 2011-03-05 11:29 ` Mark Brown 0 siblings, 1 reply; 4+ messages in thread From: Randy Dunlap @ 2011-03-05 1:33 UTC (permalink / raw) To: Stephen Rothwell, Zeng Zhaoming Cc: alsa-devel, Mark Brown, LKML, linux-next, Liam, Girdwood From: Randy Dunlap <randy.dunlap@oracle.com> sgtl5000 uses regulator interfaces, so make selecting it depend on REGULATOR. sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register' Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Zeng Zhaoming <zhaoming.zeng@freescale.com> --- sound/soc/codecs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20110304.orig/sound/soc/codecs/Kconfig +++ linux-next-20110304/sound/soc/codecs/Kconfig @@ -33,7 +33,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_MAX98088 if I2C select SND_SOC_MAX9877 if I2C select SND_SOC_PCM3008 - select SND_SOC_SGTL5000 if I2C + select SND_SOC_SGTL5000 if I2C && REGULATOR select SND_SOC_SN95031 if INTEL_SCU_IPC select SND_SOC_SPDIF select SND_SOC_SSM2602 if I2C ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces 2011-03-05 1:33 ` [PATCH -next] soc: sgtl5000 uses regulator interfaces Randy Dunlap @ 2011-03-05 11:29 ` Mark Brown 2011-03-05 12:41 ` Zeng Zhaoming 0 siblings, 1 reply; 4+ messages in thread From: Mark Brown @ 2011-03-05 11:29 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Zeng Zhaoming, linux-next, LKML, Liam Girdwood, alsa-devel On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote: > From: Randy Dunlap <randy.dunlap@oracle.com> > > sgtl5000 uses regulator interfaces, so make selecting it depend > on REGULATOR. > > sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' > sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' > sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register' Since the regulator on the device is optional this isn't the best fix, the code should be updated to support building without regulator. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces 2011-03-05 11:29 ` Mark Brown @ 2011-03-05 12:41 ` Zeng Zhaoming 2011-03-15 15:41 ` Randy Dunlap 0 siblings, 1 reply; 4+ messages in thread From: Zeng Zhaoming @ 2011-03-05 12:41 UTC (permalink / raw) To: Mark Brown Cc: Randy Dunlap, Stephen Rothwell, Zeng Zhaoming, linux-next, LKML, Liam Girdwood, alsa-devel On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote: >> From: Randy Dunlap <randy.dunlap@oracle.com> >> >> sgtl5000 uses regulator interfaces, so make selecting it depend >> on REGULATOR. >> >> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' >> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' >> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register' > hi， Thanks for the report. > Since the regulator on the device is optional this isn't the best fix, > the code should be updated to support building without regulator. I will fix the code. If regulator not enabled, and the optional regulator not provided externally, a warning message will print out, and internal regulator will set directly by write register. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Best Regards Zeng Zhaoming ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] soc: sgtl5000 uses regulator interfaces 2011-03-05 12:41 ` Zeng Zhaoming @ 2011-03-15 15:41 ` Randy Dunlap 0 siblings, 0 replies; 4+ messages in thread From: Randy Dunlap @ 2011-03-15 15:41 UTC (permalink / raw) To: Zeng Zhaoming Cc: Stephen Rothwell, alsa-devel, Mark Brown, LKML, linux-next, Zeng Zhaoming, Liam, Girdwood On Sat, 5 Mar 2011 20:41:38 +0800 Zeng Zhaoming wrote: > On Sat, Mar 5, 2011 at 7:29 PM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: > > On Fri, Mar 04, 2011 at 05:33:57PM -0800, Randy Dunlap wrote: > >> From: Randy Dunlap <randy.dunlap@oracle.com> > >> > >> sgtl5000 uses regulator interfaces, so make selecting it depend > >> on REGULATOR. > >> > >> sgtl5000.c:(.text+0x4ae33): undefined reference to `regulator_unregister' > >> sgtl5000.c:(.text+0x4af41): undefined reference to `rdev_get_drvdata' > >> sgtl5000.c:(.text+0x4b191): undefined reference to `regulator_register' > > > > hi， Thanks for the report. > > > Since the regulator on the device is optional this isn't the best fix, > > the code should be updated to support building without regulator. > > I will fix the code. If regulator not enabled, and the optional > regulator not provided externally, > a warning message will print out, and internal regulator will set > directly by write register. > > -- ping. This build error still happens in linux-next 2011.0315. --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-03-15 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110304180027.20deb6c4.sfr@canb.auug.org.au>
2011-03-05 1:33 ` [PATCH -next] soc: sgtl5000 uses regulator interfaces Randy Dunlap
2011-03-05 11:29 ` Mark Brown
2011-03-05 12:41 ` Zeng Zhaoming
2011-03-15 15:41 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).