From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Takashi Iwai <tiwai@suse.de>,
patches@opensource.wolfsonmicro.com, lrg@ti.com,
lrg@slimlogic.co.uk
Subject: Re: [PATCH 1/2 v2] ALSA: Add snd_ctl_update() to dynamically update a control
Date: Tue, 15 Mar 2011 16:27:28 +0000 [thread overview]
Message-ID: <20110315162728.GA27777@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D7F7516.7050009@ladisch.de>
On Tue, Mar 15, 2011 at 03:17:58PM +0100, Clemens Ladisch wrote:
> Doing this outside the semaphore doesn't look good.
Yes, I was thinking about the same thing, wasn't sure about nesting rw
semaphores though.
> I wonder whether snd_ctl_add() is the right function to use, because it
> will assign a different numid event if the control didn't change.
Hm, indeed. I can probably inline a slightly different version of
snd_ctl_add()?
> > A separate patch needs to be made to make ALSA Mixer cope with this.
>
> What happens?
It doesn't break or anything hopefully. It will probably need support for
handling the update of the controls (without exiting and starting it
again). I've only tested it against alsa-utils 1.0.20 and it worked
fine with a few changes (updating the controls on the fly).
Thanks,
Dimitris
next prev parent reply other threads:[~2011-03-15 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 12:31 [PATCH 1/2 v2] ALSA: Add snd_ctl_update() to dynamically update a control Dimitris Papastamos
2011-03-15 12:31 ` [PATCH 2/2 v2] ASoC: soc-core: Add helper function to handle dynamic update of controls Dimitris Papastamos
2011-03-15 14:17 ` [PATCH 1/2 v2] ALSA: Add snd_ctl_update() to dynamically update a control Clemens Ladisch
2011-03-15 14:25 ` Takashi Iwai
2011-03-16 0:56 ` Raymond Yau
2011-03-16 7:01 ` Takashi Iwai
2011-03-15 16:27 ` Dimitris Papastamos [this message]
2011-03-16 8:05 ` Raymond Yau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315162728.GA27777@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=clemens@ladisch.de \
--cc=lrg@slimlogic.co.uk \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).