From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: rajeev <rajeev-dlh.kumar@st.com>
Cc: Takashi Iwai <tiwai@suse.de>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
lrg@slimlogic.co.uk
Subject: Re: RFC: ST specific ASoC sound driver
Date: Wed, 16 Mar 2011 11:22:14 +0000 [thread overview]
Message-ID: <20110316112214.GB14125@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4D809928.2000905@st.com>
On Wed, Mar 16, 2011 at 04:34:08PM +0530, rajeev wrote:
Please remember to CC maintainers on mails - I've added Liam.
> I have developed a ASoC sound driver for a ST specific platform (SPEAr).
> This module actually uses the Designware (Synopsys) "dw_apb_i2s_db" IP
> + some ST specific glue logic on top of it.
> Now I am confused as to whether I should submit a single patch for
> the SPEAr ASoC driver or should I try to break the driver such that
> the Designware and glue logic parts are handled separately (which given
> the current shape of design seems improbable)
Ideally it'd be split so other people could share the off the shelf
DesignWare code if they also use the IP but it really depends on what
exactly the ST specific customisations do and how much control is
required for the generic part - if the control for the IP is trivial
or the changes are very invasive then there's less value in splitting
it. Without seeing the code it's difficult to comment.
prev parent reply other threads:[~2011-03-16 11:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-16 11:04 RFC: ST specific ASoC sound driver rajeev
2011-03-16 11:22 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316112214.GB14125@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=rajeev-dlh.kumar@st.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).