Re: [PATCH] ASoC: Add National Semiconductor LM49352 Codec Support

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Wed, Mar 16, 2011 at 06:38:15AM -0700, Reddy, MR Swami wrote:
> >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com] 

Please fix your MUA to word wrap at less than 80 columns within
paragraphs.

> >As previously mentioned this is pretty much up to you - you can apply
> >a range of techniques, either from starting from >scratch or
> >reviewing the kernel changelogs for the core and other drivers and
> >making gradual changes to forward port.  >Which approach works best
> >for you is largely a matter of personal preference.  If you have
> >questions on specific things >then please feel free to ask.

> OK. I will look into the kernel changelogs and update the LM49352
> driver to use the latest ALSA APIs and sync with latest kernel
> sources. If there are any other comments (ie apart from the coding
> standards), please let me know.

Given the great age of the kernel you were developing against I didn't
really look at the code, there has been substantial change in the kernel
since then.

> >I've had a brief glance at the driver and there are a number of
> >obvious coding style issues, please before resubmitting >review the
> >coding style you are using and ensure that your driver is following a
> >similar coding style to the existing >kernel code.  For example
> >comments like this:

> I ran the scripts/chcekpatch.pl script for lm49352.c and lm49352.h
> file, there no warnings/errors.  OK, I could remove the comments for
> all functions in the next patch submission.

It's not about passing checkpatch, it's about making sure your code
looks like other similar code.  If you look at your code next to
another, similar driver and it's easy to tell which is which visually
there's an issue.  checkpatch is a useful tool but it's only part of
making sure your code is idiomatic for the kernel.