alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register
@ 2011-03-24  6:58 Peter Ujfalusi
  2011-03-24 10:15 ` Mark Brown
  2011-03-26 15:53 ` Liam Girdwood
  0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2011-03-24  6:58 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, Liam Girdwood

Register 0x40, 0x41 need to be restored after power up, since
it contains gain related fields, which affects playback volume.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
 sound/soc/codecs/tlv320dac33.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/sound/soc/codecs/tlv320dac33.c b/sound/soc/codecs/tlv320dac33.c
index 93f38b1..6c3735d 100644
--- a/sound/soc/codecs/tlv320dac33.c
+++ b/sound/soc/codecs/tlv320dac33.c
@@ -324,6 +324,10 @@ static void dac33_init_chip(struct snd_soc_codec *codec)
 	dac33_write(codec, DAC33_OUT_AMP_CTRL,
 		    dac33_read_reg_cache(codec, DAC33_OUT_AMP_CTRL));
 
+	dac33_write(codec, DAC33_LDAC_PWR_CTRL,
+		    dac33_read_reg_cache(codec, DAC33_LDAC_PWR_CTRL));
+	dac33_write(codec, DAC33_RDAC_PWR_CTRL,
+		    dac33_read_reg_cache(codec, DAC33_RDAC_PWR_CTRL));
 }
 
 static inline int dac33_read_id(struct snd_soc_codec *codec)
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register
  2011-03-24  6:58 [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register Peter Ujfalusi
@ 2011-03-24 10:15 ` Mark Brown
  2011-03-26 15:53 ` Liam Girdwood
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2011-03-24 10:15 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: alsa-devel, Liam Girdwood

On Thu, Mar 24, 2011 at 08:58:05AM +0200, Peter Ujfalusi wrote:
> Register 0x40, 0x41 need to be restored after power up, since
> it contains gain related fields, which affects playback volume.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register
  2011-03-24  6:58 [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register Peter Ujfalusi
  2011-03-24 10:15 ` Mark Brown
@ 2011-03-26 15:53 ` Liam Girdwood
  1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2011-03-26 15:53 UTC (permalink / raw)
  To: Peter Ujfalusi; +Cc: alsa-devel, Mark Brown

On Thu, 2011-03-24 at 08:58 +0200, Peter Ujfalusi wrote:
> Register 0x40, 0x41 need to be restored after power up, since
> it contains gain related fields, which affects playback volume.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
>  sound/soc/codecs/tlv320dac33.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 

Applied.

Thanks

Liam

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-03-26 15:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-24  6:58 [PATCH] ASoC: tlv320dac33: Restore L/R DAC power control register Peter Ujfalusi
2011-03-24 10:15 ` Mark Brown
2011-03-26 15:53 ` Liam Girdwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).