From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: Scott Jiang <scott.jiang@analog.com>,
alsa-devel@alsa-project.org, Cliff Cai <cliff.cai@analog.com>,
device-drivers-devel@blackfin.uclinux.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: ad74111: new codec driver
Date: Sat, 26 Mar 2011 12:21:08 +0000 [thread overview]
Message-ID: <20110326122108.GD28537@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301128426-2817-1-git-send-email-vapier@gentoo.org>
On Sat, Mar 26, 2011 at 04:33:46AM -0400, Mike Frysinger wrote:
> select SND_SOC_AD1980 if SND_SOC_AC97_BUS
> - select SND_SOC_ADS117X
> select SND_SOC_AD73311 if I2C
> + select SND_SOC_AD74111
> + select SND_SOC_ADS117X
A few of your patches have this sort of additional change in them.
While the cleanup is good it would be better to split it into a separate
patch. Seeing the unrelated change slows down review and it'll also
create extra merge issues when applying or cherry picking the driver
back to older kernels.
> +static struct platform_driver ad74111_codec_driver = {
> + .driver = {
> + .name = "ad74111-codec",
Again, drop the -codec unless this is part of a MFD.
> +/*
> + * definitions for AD74111 registers
> + *
Does this device really have registers? There's no reference at all to
them in the driver.
> +/* Control register F */
> +#define CTRL_REG_F (5 << 11)
> +#define REGF_DAC_VOL(x) ((x) & 0x3F)
If the registers should be here they should be namespaced.
next prev parent reply other threads:[~2011-03-26 12:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 8:33 [PATCH] ASoC: ad74111: new codec driver Mike Frysinger
2011-03-26 12:21 ` Mark Brown [this message]
2011-03-26 17:52 ` [Device-drivers-devel] " Mike Frysinger
2011-03-26 18:09 ` Mark Brown
2011-03-27 4:10 ` Mike Frysinger
2011-03-27 13:43 ` Mark Brown
2011-03-28 7:22 ` Mike Frysinger
2011-03-29 21:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326122108.GD28537@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=lrg@slimlogic.co.uk \
--cc=scott.jiang@analog.com \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).