From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: alsa-devel@alsa-project.org, Cliff Cai <cliff.cai@analog.com>,
device-drivers-devel@blackfin.uclinux.org,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/2] ASoC: SSM2602: drop rate and sample bits constraints
Date: Sat, 26 Mar 2011 12:44:09 +0000 [thread overview]
Message-ID: <20110326124409.GF28537@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301124539-527-1-git-send-email-vapier@gentoo.org>
On Sat, Mar 26, 2011 at 03:28:58AM -0400, Mike Frysinger wrote:
> From: Cliff Cai <cliff.cai@analog.com>
>
> Signed-off-by: Cliff Cai <cliff.cai@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
I suspect this change is incomplete and should also be setting the
symmetric_rates flag in the driver which does the equivalent thing in
the core as this code is doing. Looking at the code some symmetry
handling is required as the driver is setting the same registers for
playback and capture rates so simultaneous playback and record with
different rates is not supported?
Converting to symmetric_rates would definitely be a good thing.
next prev parent reply other threads:[~2011-03-26 12:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 7:28 [PATCH 1/2] ASoC: SSM2602: drop rate and sample bits constraints Mike Frysinger
2011-03-26 7:28 ` [PATCH 2/2] ASoC: SSM2602: convert to soc-cache Mike Frysinger
2011-03-26 7:36 ` [PATCH 2/2 v2] " Mike Frysinger
2011-03-26 12:48 ` Mark Brown
2011-03-27 4:09 ` [Device-drivers-devel] " Mike Frysinger
2011-03-27 10:36 ` Mark Brown
2011-03-27 15:07 ` Mike Frysinger
2011-03-27 18:18 ` Mark Brown
2011-03-26 17:36 ` Mark Brown
2011-03-27 4:45 ` [PATCH " Mike Frysinger
2011-03-27 4:59 ` [PATCH v3] " Mike Frysinger
2011-03-27 21:14 ` [PATCH v5] " Mike Frysinger
2011-03-27 22:14 ` [Device-drivers-devel] " Mike Frysinger
2011-03-29 20:27 ` Liam Girdwood
2011-03-27 21:22 ` [PATCH v6] " Mike Frysinger
2011-03-29 20:29 ` Liam Girdwood
2011-03-29 22:18 ` Mark Brown
2011-03-26 12:44 ` Mark Brown [this message]
2011-03-27 4:07 ` [Device-drivers-devel] [PATCH 1/2] ASoC: SSM2602: drop rate and sample bits constraints Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326124409.GF28537@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=cliff.cai@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=lrg@slimlogic.co.uk \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).