From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
lrg@ti.com, lrg@slimlogic.co.uk
Subject: Re: [PATCH 3/3] ASoC: soc-cache: Ignore !codec->writable_register() during syncing
Date: Sat, 26 Mar 2011 17:29:41 +0000 [thread overview]
Message-ID: <20110326172941.GA3535@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1300974319-14423-3-git-send-email-dp@opensource.wolfsonmicro.com>
On Thu, Mar 24, 2011 at 01:45:19PM +0000, Dimitris Papastamos wrote:
> When syncing the cache, if the driver has given us a writable_register()
> callback, use it to not sync any non-writable registers.
>
> Signed-off-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Thinking about this again I'm actually thinking we should really be
warning if we ever find a need to sync a non-writable register - given
that we suppress writes of the default value this'd mean that we'd have
had to have written to the register at some point in the past which
means that something messed up somewhere.
next prev parent reply other threads:[~2011-03-26 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 13:45 [PATCH 1/3] ASoC: Add default snd_soc_default_writable_register() callback Dimitris Papastamos
2011-03-24 13:45 ` [PATCH 2/3] ASoC: Add snd_soc_codec_{readable, writable}_register() Dimitris Papastamos
2011-03-24 13:45 ` [PATCH 3/3] ASoC: soc-cache: Ignore !codec->writable_register() during syncing Dimitris Papastamos
2011-03-26 17:29 ` Mark Brown [this message]
2011-03-28 9:35 ` Dimitris Papastamos
2011-03-26 12:51 ` [PATCH 1/3] ASoC: Add default snd_soc_default_writable_register() callback Liam Girdwood
2011-03-26 17:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326172941.GA3535@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=dp@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).