From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dimitris Papastamos Subject: Re: [PATCH 3/3] ASoC: soc-cache: Ignore !codec->writable_register() during syncing Date: Mon, 28 Mar 2011 10:35:01 +0100 Message-ID: <20110328093501.GA20628@opensource.wolfsonmicro.com> References: <1300974319-14423-1-git-send-email-dp@opensource.wolfsonmicro.com> <1300974319-14423-3-git-send-email-dp@opensource.wolfsonmicro.com> <20110326172941.GA3535@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 22D0F1038FD for ; Mon, 28 Mar 2011 11:35:05 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20110326172941.GA3535@opensource.wolfsonmicro.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, lrg@ti.com, lrg@slimlogic.co.uk List-Id: alsa-devel@alsa-project.org On Sat, Mar 26, 2011 at 05:29:41PM +0000, Mark Brown wrote: > On Thu, Mar 24, 2011 at 01:45:19PM +0000, Dimitris Papastamos wrote: > > When syncing the cache, if the driver has given us a writable_register() > > callback, use it to not sync any non-writable registers. > > > > Signed-off-by: Dimitris Papastamos > > Thinking about this again I'm actually thinking we should really be > warning if we ever find a need to sync a non-writable register - given > that we suppress writes of the default value this'd mean that we'd have > had to have written to the register at some point in the past which > means that something messed up somewhere. Yea that makes sense. I will send in a patch. Thanks, Dimitris