From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: spi codec names in machine drivers
Date: Thu, 31 Mar 2011 06:20:17 +0900 [thread overview]
Message-ID: <20110330212016.GC20496@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <AANLkTi=Vtzxu5pzaActNXc0J1ssbS1djrTfbKnBd3Gq=@mail.gmail.com>
On Tue, Mar 29, 2011 at 02:05:04AM -0400, Mike Frysinger wrote:
> after the recent multi-component patch, spi codec names were changed
> to "<name>.<spics>" in the machine drivers. so if we have an ad193x
> codec on spi bus 0 cs 5, the name is now "ad193x.5".
>
> this also seems to be how fmt_single_name in soc-core.c is doing
> things. am i reading this right ?
>
> what if i have two codecs on two different spi busses but happen to
> have the same cs ? shouldnt the spi code do the same as i2c and
> include the bus in the id naming ?
I think we should just switch to using dev_name() everywhere.
next prev parent reply other threads:[~2011-03-30 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 6:05 spi codec names in machine drivers Mike Frysinger
2011-03-30 21:20 ` Mark Brown [this message]
2011-03-30 21:58 ` Mike Frysinger
2011-03-31 0:11 ` Mark Brown
2011-03-31 0:15 ` Mike Frysinger
2011-03-31 0:30 ` Mark Brown
2011-03-31 0:32 ` Mike Frysinger
2011-04-07 6:07 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330212016.GC20496@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).