From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: spi codec names in machine drivers Date: Thu, 31 Mar 2011 06:20:17 +0900 Message-ID: <20110330212016.GC20496@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id EA4FD1039FD for ; Wed, 30 Mar 2011 23:20:08 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Mike Frysinger Cc: alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Tue, Mar 29, 2011 at 02:05:04AM -0400, Mike Frysinger wrote: > after the recent multi-component patch, spi codec names were changed > to "." in the machine drivers. so if we have an ad193x > codec on spi bus 0 cs 5, the name is now "ad193x.5". > > this also seems to be how fmt_single_name in soc-core.c is doing > things. am i reading this right ? > > what if i have two codecs on two different spi busses but happen to > have the same cs ? shouldnt the spi code do the same as i2c and > include the bus in the id naming ? I think we should just switch to using dev_name() everywhere.