From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH 2/2] ASoC: rename dapm_generic_apply_power()
Date: Sat, 2 Apr 2011 16:35:29 +0900 [thread overview]
Message-ID: <20110402073527.GA28417@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301729016-355-2-git-send-email-guanqun.lu@intel.com>
On Sat, Apr 02, 2011 at 03:23:36PM +0800, Lu Guanqun wrote:
> dapm_generic_apply_power() is only called in dapm_seq_run() when w->id is
> snd_soc_dapm_{input|output|hp|line|mic}. So, it's not a generic function at
> all, we better rename it to reflect what it's doing.
I don't think you've really understood what the code is doing here.
While it's true that we don't ever call this function for most widget
types due to the write compression code it is actually the generic
method for applying power changes to a widget in isolation - it does a
register update surrounded by the event callbacks in the appropriate
sequence which really is something that is generic to all widgets. A
better question if you want to refector the code here would be why these
widgets are treated differently to other widgets.
next prev parent reply other threads:[~2011-04-02 7:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 7:23 [PATCH 1/2] ASoC: remove dapm_update_bits() Lu Guanqun
2011-04-02 7:23 ` [PATCH 2/2] ASoC: rename dapm_generic_apply_power() Lu Guanqun
2011-04-02 7:35 ` Mark Brown [this message]
2011-04-02 7:44 ` Lu Guanqun
2011-04-02 7:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110402073527.GA28417@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=guanqun.lu@intel.com \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).