From: Tarek Soliman <tarek@bashasoliman.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
Date: Mon, 4 Apr 2011 09:26:52 -0500 [thread overview]
Message-ID: <20110404142652.GA3841@zeus.olympus> (raw)
In-Reply-To: <s5h62quv0h3.wl%tiwai@suse.de>
On Mon, Apr 04, 2011 at 11:18:16AM +0200, Takashi Iwai wrote:
> At Sun, 3 Apr 2011 01:51:22 -0500,
> Tarek Soliman wrote:
> >
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> >
> > This patch adds the ID of yet another one of those cables
> >
> > Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> > ---
> > sound/usb/midi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..bdf5d9d 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> > case USB_ID(0x0a92, 0x1020): /* ESI M4U */
> > case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
> > case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> > + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> > case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> > case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
>
> The entries are sorted in the vendor id order.
> Could you fix the point to insert and resend the patch?
>
>
> thanks,
>
> Takashi
I did so. It should be a new thread in the mailing list.
--
Tarek
next prev parent reply other threads:[~2011-04-04 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 6:51 [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable Tarek Soliman
2011-04-04 9:18 ` Takashi Iwai
2011-04-04 14:26 ` Tarek Soliman [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-04 14:23 Tarek Soliman
2011-04-06 2:35 ` Tarek Soliman
2011-04-06 6:06 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404142652.GA3841@zeus.olympus \
--to=tarek@bashasoliman.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).