* [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
@ 2011-04-03 6:51 Tarek Soliman
2011-04-04 9:18 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Tarek Soliman @ 2011-04-03 6:51 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: alsa-devel
There are many USB MIDI cables out there that have buggy
firmware that reports it can do more than 4 bytes in a
packet when they can only properly handle 4
This patch adds the ID of yet another one of those cables
Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
---
sound/usb/midi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index b4b39c0..bdf5d9d 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
case USB_ID(0x0a92, 0x1020): /* ESI M4U */
case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
+ case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
ep->max_transfer = 4;
--
1.7.4.1
--
Tarek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
2011-04-03 6:51 [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable Tarek Soliman
@ 2011-04-04 9:18 ` Takashi Iwai
2011-04-04 14:26 ` Tarek Soliman
0 siblings, 1 reply; 6+ messages in thread
From: Takashi Iwai @ 2011-04-04 9:18 UTC (permalink / raw)
To: Tarek Soliman; +Cc: alsa-devel, Clemens Ladisch
At Sun, 3 Apr 2011 01:51:22 -0500,
Tarek Soliman wrote:
>
> There are many USB MIDI cables out there that have buggy
> firmware that reports it can do more than 4 bytes in a
> packet when they can only properly handle 4
>
> This patch adds the ID of yet another one of those cables
>
> Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> ---
> sound/usb/midi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index b4b39c0..bdf5d9d 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> case USB_ID(0x0a92, 0x1020): /* ESI M4U */
> case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
> case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
The entries are sorted in the vendor id order.
Could you fix the point to insert and resend the patch?
thanks,
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
@ 2011-04-04 14:23 Tarek Soliman
2011-04-06 2:35 ` Tarek Soliman
0 siblings, 1 reply; 6+ messages in thread
From: Tarek Soliman @ 2011-04-04 14:23 UTC (permalink / raw)
To: Clemens Ladisch; +Cc: alsa-devel
There are many USB MIDI cables out there that have buggy
firmware that reports it can do more than 4 bytes in a
packet when they can only properly handle 4
This patch adds the ID of yet another one of those cables
Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
---
sound/usb/midi.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index b4b39c0..f928910 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
+ case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
ep->max_transfer = 4;
break;
/*
--
1.7.4.1
As instructed, I updated the insertion point of the new entry such
that the entries are sorted.
--
Tarek
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
2011-04-04 9:18 ` Takashi Iwai
@ 2011-04-04 14:26 ` Tarek Soliman
0 siblings, 0 replies; 6+ messages in thread
From: Tarek Soliman @ 2011-04-04 14:26 UTC (permalink / raw)
To: alsa-devel
On Mon, Apr 04, 2011 at 11:18:16AM +0200, Takashi Iwai wrote:
> At Sun, 3 Apr 2011 01:51:22 -0500,
> Tarek Soliman wrote:
> >
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> >
> > This patch adds the ID of yet another one of those cables
> >
> > Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> > ---
> > sound/usb/midi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..bdf5d9d 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1299,6 +1299,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> > case USB_ID(0x0a92, 0x1020): /* ESI M4U */
> > case USB_ID(0x1430, 0x474b): /* RedOctane GH MIDI INTERFACE */
> > case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> > + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> > case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> > case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
>
> The entries are sorted in the vendor id order.
> Could you fix the point to insert and resend the patch?
>
>
> thanks,
>
> Takashi
I did so. It should be a new thread in the mailing list.
--
Tarek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
2011-04-04 14:23 Tarek Soliman
@ 2011-04-06 2:35 ` Tarek Soliman
2011-04-06 6:06 ` Takashi Iwai
0 siblings, 1 reply; 6+ messages in thread
From: Tarek Soliman @ 2011-04-06 2:35 UTC (permalink / raw)
To: alsa-devel
On Mon, Apr 04, 2011 at 09:23:53AM -0500, Tarek Soliman wrote:
> There are many USB MIDI cables out there that have buggy
> firmware that reports it can do more than 4 bytes in a
> packet when they can only properly handle 4
>
> This patch adds the ID of yet another one of those cables
>
> Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> ---
> sound/usb/midi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> index b4b39c0..f928910 100644
> --- a/sound/usb/midi.c
> +++ b/sound/usb/midi.c
> @@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
> + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> ep->max_transfer = 4;
> break;
> /*
> --
> 1.7.4.1
>
> As instructed, I updated the insertion point of the new entry such
> that the entries are sorted.
Hi,
Is there anything else required for this to be merged?
I am very new to this.
--
Tarek
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable
2011-04-06 2:35 ` Tarek Soliman
@ 2011-04-06 6:06 ` Takashi Iwai
0 siblings, 0 replies; 6+ messages in thread
From: Takashi Iwai @ 2011-04-06 6:06 UTC (permalink / raw)
To: Tarek Soliman; +Cc: alsa-devel
At Tue, 5 Apr 2011 21:35:12 -0500,
Tarek Soliman wrote:
>
> On Mon, Apr 04, 2011 at 09:23:53AM -0500, Tarek Soliman wrote:
> > There are many USB MIDI cables out there that have buggy
> > firmware that reports it can do more than 4 bytes in a
> > packet when they can only properly handle 4
> >
> > This patch adds the ID of yet another one of those cables
> >
> > Signed-off-by: Tarek Soliman <tarek@bashasoliman.com>
> > ---
> > sound/usb/midi.c | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/sound/usb/midi.c b/sound/usb/midi.c
> > index b4b39c0..f928910 100644
> > --- a/sound/usb/midi.c
> > +++ b/sound/usb/midi.c
> > @@ -1301,6 +1301,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi* umidi,
> > case USB_ID(0x15ca, 0x0101): /* Textech USB Midi Cable */
> > case USB_ID(0x15ca, 0x1806): /* Textech USB Midi Cable */
> > case USB_ID(0x1a86, 0x752d): /* QinHeng CH345 "USB2.0-MIDI" */
> > + case USB_ID(0xfc08, 0x0101): /* Unknown vendor Cable */
> > ep->max_transfer = 4;
> > break;
> > /*
> > --
> > 1.7.4.1
> >
> > As instructed, I updated the insertion point of the new entry such
> > that the entries are sorted.
>
> Hi,
>
> Is there anything else required for this to be merged?
> I am very new to this.
Your new patch is fine. I applied it now.
Thanks!
Takashi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-06 6:06 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-03 6:51 [PATCH] ALSA: usb-audio: define another USB ID for a buggy USB MIDI cable Tarek Soliman
2011-04-04 9:18 ` Takashi Iwai
2011-04-04 14:26 ` Tarek Soliman
-- strict thread matches above, loose matches on Subject: below --
2011-04-04 14:23 Tarek Soliman
2011-04-06 2:35 ` Tarek Soliman
2011-04-06 6:06 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).