From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [patch 1/1] sgtl5000: Fix suspend/resume
Date: Tue, 5 Apr 2011 09:18:59 +0900 [thread overview]
Message-ID: <20110405001858.GD5376@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110404151315.251129690@rtp-net.org>
On Mon, Apr 04, 2011 at 05:13:00PM +0200, Arnaud Patard wrote:
> /* default value of sgtl5000 registers except DAP */
> -static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET >> 1] = {
> +static const u16 sgtl5000_regs[SGTL5000_MAX_REG_OFFSET] = {
> 0xa011, /* 0x0000, CHIP_ID. 11 stand for revison 17 */
> + 0,
It's not immediately obvious that this is the best fix - the driver does
declare a step of 2 so I'd expect it to be able to lay out the cahce
defaults like this. Also, it'd be easier to review the patch if you
could split out the cache stride fix from the rest of the changes,
there's quite a few things going on in this patch.
next prev parent reply other threads:[~2011-04-05 0:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 15:13 [patch 1/1] sgtl5000: Fix suspend/resume Arnaud Patard
2011-04-05 0:18 ` Mark Brown [this message]
2011-04-05 7:56 ` Arnaud Patard
2011-04-05 23:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405001858.GD5376@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).