From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Stephen Warren <swarren@nvidia.com>
Cc: Jordan Nien <JNien@nvidia.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Dilan Lee <dilee@nvidia.com>
Subject: Re: WM8903 line output mute/volume, and POWER_MANAGEMENT_3
Date: Thu, 7 Apr 2011 08:02:02 +0900 [thread overview]
Message-ID: <20110406230201.GC5297@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF0493EB374D@HQMAIL01.nvidia.com>
On Wed, Apr 06, 2011 at 01:28:15PM -0700, Stephen Warren wrote:
> Below is a patch from a colleague that fixes this. Is it correct? I see
> precedent for this sequencing setup in the Speaker PGA setup. However, the
> datasheet implies (by considering together in the same section) that the Line
> and Headphone Output PGAs are typically programmed in the same fashion, and
> they already were in the code. Perhaps the Headphone Output PGA also has an
> issue and needs similar rework?
They both need a similar change, yes. This is due to an error in an
earlier revision of the datasheet which incorrectly listed the PGA
enables in the power management registers as being copies of the ouput
first stage enables.
prev parent reply other threads:[~2011-04-06 23:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 20:28 WM8903 line output mute/volume, and POWER_MANAGEMENT_3 Stephen Warren
2011-04-06 23:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406230201.GC5297@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=JNien@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=dilee@nvidia.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox