From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: alsa-devel@alsa-project.org, Barry Song <bs14@csr.com>,
Takashi Iwai <tiwai@suse.de>, Zhiwu Song <zhiwu.song@csr.com>,
Binghua Duan <binghua.duan@csr.com>,
lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: prevent compilers from optimising pll calculation into __aeabi__uldivmod
Date: Wed, 27 Apr 2011 09:49:04 +0100 [thread overview]
Message-ID: <20110427084904.GA16666@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTi=RuNgN_+26GBrwoHJuz1xSM=YcfQ@mail.gmail.com>
On Wed, Apr 27, 2011 at 04:24:44PM +0800, Barry Song wrote:
> 2011/4/27 Takashi Iwai <tiwai@suse.de>:
> > Don't do this in the low driver level. If any, we should fix do_div()
> > instead.
> do_div is just a macro, it has no problem by itself. only while
> working together with other more codes before do_div, gcc can make
> some codes merging and cause problems.
> if do_div is a function, we'd just fix it.
It's a macro which expands to a problem so we should make it expand to
something which includes the fix as well rather than going round and
fixing each and every caller.
next prev parent reply other threads:[~2011-04-27 8:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 7:27 [PATCH] ASoC: prevent compilers from optimising pll calculation into __aeabi__uldivmod Barry Song
2011-04-27 8:19 ` Takashi Iwai
2011-04-27 8:24 ` Barry Song
2011-04-27 8:41 ` Takashi Iwai
2011-04-27 8:50 ` Barry Song
2011-04-27 14:30 ` Mark Brown
[not found] ` <20110427143002.GC31952-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-04-27 15:00 ` [alsa-devel] " Barry Song
2011-04-27 15:12 ` Mark Brown
[not found] ` <20110427151249.GE31952-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>
2011-04-27 15:23 ` [alsa-devel] " Barry Song
[not found] ` <BANLkTin4y192A0Jdujv2t5tjoccmUBzQMQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-27 15:28 ` Barry Song
2011-04-27 22:30 ` Michael Hope
2011-04-28 11:40 ` Mark Brown
2011-04-27 8:49 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-04-27 14:59 Stephen Warren
2011-04-27 15:06 ` Mark Brown
2011-04-27 15:09 ` Barry Song
2011-04-27 15:45 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427084904.GA16666@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=binghua.duan@csr.com \
--cc=bs14@csr.com \
--cc=lrg@slimlogic.co.uk \
--cc=tiwai@suse.de \
--cc=zhiwu.song@csr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox