From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Lu Guanqun <guanqun.lu@intel.com>
Cc: Takashi Iwai <tiwai@suse.de>, Koul Vinod <vinod.koul@intel.com>,
ALSA <alsa-devel@alsa-project.org>, Liam Girdwood <lrg@ti.com>,
Wang Xingchao <xingchao.wang@intel.com>
Subject: Re: [PATCH v2 07/10] ASoC: upd9976: add jack detection function
Date: Fri, 6 May 2011 13:53:11 +0100 [thread overview]
Message-ID: <20110506125308.GI23729@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110506054634.26312.80750.stgit@localhost>
On Fri, May 06, 2011 at 01:46:34PM +0800, Lu Guanqun wrote:
> + if (interrupt_status & 0x1 && value == 0x1)
> + status |= SND_JACK_HEADSET;
> +
> + if (interrupt_status & 0x2 && value == 0x2)
> + status |= SND_JACK_HEADPHONE;
> +
> + if (interrupt_status & 0x4)
> + status |= SND_JACK_HEADSET | SND_JACK_BTN_0;
> +
> + if (interrupt_status & 0x8)
> + status |= SND_JACK_HEADSET | SND_JACK_BTN_1;
It's very strange that you do a mix of checks with and without the == -
it doesn't matter either way but it'd be clearer to be consistent.
> + if (upd9976->irq < 0 || !upd9976->irq_mem)
> + return 0;
It'd seem better to have this condition the other way around so if you
need to add more conditional stuff things will be clearer.
next prev parent reply other threads:[~2011-05-06 12:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 5:45 [PATCH v2 00/10] ASoC Support For Moorestown Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 01/10] ASoC: upd9976: Add Renesas uPD9976 codec driver Lu Guanqun
2011-05-06 10:17 ` Mark Brown
2011-05-07 14:21 ` Lu Guanqun
2011-05-07 14:27 ` Mark Brown
2011-05-07 14:43 ` Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 02/10] ASoC: sst_platform: modify current cpu dai driver to suit the needs for moorestown platform Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 03/10] ASoC: mrst_machine: add moorestown machine driver Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 04/10] ASoC: upd9976: add capture ability for dai driver Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 05/10] ASoC: upd9976: add DMIC support Lu Guanqun
2011-05-06 11:07 ` Mark Brown
2011-05-06 5:46 ` [PATCH v2 06/10] ASoC: upd9976: add Analog MIC support Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 07/10] ASoC: upd9976: add jack detection function Lu Guanqun
2011-05-06 12:53 ` Mark Brown [this message]
2011-05-06 5:46 ` [PATCH v2 08/10] ASoC: mrst_machine: add capture functionality Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 09/10] ASoC: mrst_machine: add jack detection support Lu Guanqun
2011-05-06 5:46 ` [PATCH v2 10/10] ASoC: mrst_machine: add initial config to machine driver Lu Guanqun
2011-05-06 12:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110506125308.GI23729@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=guanqun.lu@intel.com \
--cc=lrg@ti.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
--cc=xingchao.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).